Rename PartialPendingWithdrawal field index to validator_index#4043
Merged
jtraglia merged 5 commits intoethereum:devfrom Dec 9, 2024
Merged
Rename PartialPendingWithdrawal field index to validator_index#4043jtraglia merged 5 commits intoethereum:devfrom
index to validator_index#4043jtraglia merged 5 commits intoethereum:devfrom
Conversation
jtraglia
approved these changes
Dec 8, 2024
Member
jtraglia
left a comment
There was a problem hiding this comment.
I totally support this change. Thank you! Just a couple nits.
index to validator_indexindex to validator_index
mkalinin
approved these changes
Dec 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
This PR changes
PendingPartialWithdrawal.indextoPendingPartialWithdrawal.validator_index. This makes it more aligned withWithdrawaland other places where we refer toValidatorIndexasvalidator_index.Justification
In Capella, we introduced
Withdrawalwith the following definition:And in Electra, we introduced
PendingPartialWithdrawalas:The fact that we used
Withdrawal.validator_indexbutPendingPartialWithdrawal.indexis confusing. And can be misleading given we haveWithdrawal.indexwith a complete different meaning.