Skip to content

Update ERC-7744: Move to Review #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 24, 2025
Merged

Update ERC-7744: Move to Review #855

merged 5 commits into from
Jan 24, 2025

Conversation

peersky
Copy link
Contributor

@peersky peersky commented Jan 18, 2025

This PR concludes discussion that was facilitated on the Magician forums, particularly:

  • Addresses self-destruct concerns
  • Addresses EIP7702 delegated address concern
  • Changes solidity file names according to standard number
  • Changes salt and deployment address to accommodate bytecode changes
  • New artifact was compiled with no metadata included to avoid bytecode changes if somone tries to re-compile it locally

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Jan 18, 2025 •
edited
Loading

✅ All reviewers have approved.

@eip-review-bot eip-review-bot changed the title Move erc 7744 to review Update ERC-7744: Move to Review Jan 18, 2025
@github-actions GitHub Actions
Copy link

The commit 90528bc (as a parent of 903fe15) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci label Jan 18, 2025
@peersky
Copy link
Contributor Author

peersky commented Jan 18, 2025

@SamWilsn not sure how to fix the error, since required link for EIP7702 is not in this repo and AFAIK we cannot have external links as well

@poojaranjan poojaranjan mentioned this pull request Jan 20, 2025
Closed
31 tasks
@github-actions github-actions bot removed the w-ci label Jan 24, 2025
@eip-review-bot eip-review-bot enabled auto-merge (squash) January 24, 2025 20:46
eip-review-bot
eip-review-bot approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eip-review-bot eip-review-bot merged commit 96e341a into ethereum:master Jan 24, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamWilsn SamWilsn SamWilsn approved these changes

@eip-review-bot eip-review-bot eip-review-bot approved these changes

Assignees
No one assigned
Labels
c-status c-update e-review s-review t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peersky @eip-review-bot @SamWilsn