Update ERC-7578: Move to Final #850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ERC-7578 interface & reference implementation updates
Formatting for bot.
Improve documentation and standard naming
ERC-721 links
Removed external link
Add `virtual` to allow `_update` overridden implementations based on the ERC-7578
Remove `properties` field from `PropertiesRemoved` event
Fix potential linearization issue when inheriting 'ERC721' in the child contract
Update `Security Considerations` section
docs(ERC7578): address reviewer issues and suggestions
docs(ERC7578): move requirements to the specification section
Fix authors with github username
Make 'setProperties' internal and update documentation
Update getter and setter methods naming
Move ERC-7578 to last call
Co-authored-by: Sam Wilson <[email protected]>
|
✅ All reviewers have approved. |
31 tasks
SamWilsn
approved these changes
Jan 24, 2025
eip-review-bot
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: