pectra fees: tweaks from Seb's review #1609
Conversation
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Warning Rate limit exceeded@krofax has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 27 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe changes update documentation related to the Pectra upgrade’s impact on fee calculations for chains using different data availability (DA) modes. The description of EIP-7623’s effect is clarified to specify "calldata-heavy transactions." Instructions for chain operators are restructured to clearly differentiate between actions for calldata-only chains and blob DA chains. The recommended scalar multiplier for adjusting the Sequence Diagram(s)sequenceDiagram
participant Operator as Chain Operator
participant Documentation as Docs
participant Network as L2 Chain
Operator->>Documentation: Review Pectra upgrade instructions
alt Calldata-only Chain
Documentation-->>Operator: Instruct to scale BaseFeeScalar by 10/4
Operator->>Network: Adjust BaseFeeScalar accordingly
else Blob DA Chain
Documentation-->>Operator: Instruct to adjust Ecotone scalars per guide
Operator->>Network: Adjust Ecotone scalars as recommended
end
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (5)
pages/operators/chain-operators/management/blobs.mdx (1)
124-126: Use imperative voice & correct restrictive clauseChange the callout to use an imperative instruction and replace “which” with “that” for the restrictive clause. For example:
- Since the Pectra upgrade on L1, chains which exclusively use calldata DA need to scale up their BaseFeeScalar by 10/4. See [this notice](/notices/pecta-fees). + Scale up your BaseFeeScalar by 10/4 for chains that use calldata-only DA since the L1 Pectra upgrade. See [Pectra fees notice](/notices/pectra-fees) for details.pages/notices/pectra-fees.mdx (4)
22-22: Clarify and streamline EIP-7623 impact descriptionThe phrase “These include such transactions as those used by OPStack chains before the Ecotone upgrade when blob data availability (blob DA) was introduced” is wordy. Consider:
-[EIP-7623] increases the amount of gas payable for calldata-heavy transactions. These include such transactions as those used by OPStack chains *before the Ecotone upgrade* when blob data availability (blob DA) was introduced. +[EIP-7623] increases the gas cost for calldata-heavy transactions—specifically those used by OP Stack chains before the Ecotone upgrade introduced blob DA.
24-24: Tighten wording & remove unnecessary punctuation
- Replace “In order to continue to optimize” with “To continue optimizing”
- Remove the comma before “because”
- Consider shorter phrasing for “make use of”
Example:- Blob DA has now been the default and recommended option for the OPStack for some time, so almost all chains make use of it. In order to continue to optimize for chains operating with blob DA, the Optimism protocol's current DA fee pricing formula has remained unchanged despite Pectra activating on Ethereum. This allowed us to leave the base fee scalar of modern fee configurations unchanged, because it accounts for only the fixed intrinsic gas cost of 21,000 of a blob transaction. + Blob DA is now the default and recommended option for OP Stack, so almost all chains use it. To continue optimizing for chains operating with blob DA, the Optimism protocol's DA fee formula remains unchanged despite Pectra activating on Ethereum. This allows leaving the base fee scalar unchanged because it accounts only for the 21 000 gas intrinsic cost of a blob transaction.🧰 Tools
🪛 LanguageTool
[style] ~24-~24: Consider a more concise word here.
Context: ...e, so almost all chains make use of it. In order to continue to optimize for chains operati...(IN_ORDER_TO_PREMIUM)
[formatting] ~24-~24: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...r of modern fee configurations unchanged, because it accounts for only the fixed intrinsi...(COMMA_BEFORE_BECAUSE)
32-32: Use direct imperative toneRemove “Please” to match imperative style. For example:
- Please review your [Ecotone scalar chain configuration](/operators/chain-operators/management/blobs). + Review your [Ecotone scalar chain configuration](/operators/chain-operators/management/blobs).
34-37: Clarify callout with imperative phrasingRephrase to a clearer, imperative instruction. For example:
- <Callout type="info"> - If your chain uses a zero blob base fee scalar, meaning it's configured to price for calldata only, you may need to update the base fee scalar and/or the blob base fee scalar. Otherwise, no action is necessary and the rest of this section does not apply. - </Callout> + <Callout type="info"> + Chains configured with a zero blob base fee scalar (calldata-only) must update the base fee scalar and/or blob base fee scalar. No further action is required for blob DA chains. + </Callout>
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (2)
pages/notices/pectra-fees.mdx(1 hunks)pages/operators/chain-operators/management/blobs.mdx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with the following criteria: - First, check the frontmatter section at the top of the file: 1. For regular pages, ensure AL...
**/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- First, check the frontmatter section at the top of the file:
- For regular pages, ensure ALL these fields are present and not empty:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] personas: [non-empty array] categories: [non-empty array] content_type: [valid type] ---
- For landing pages (index.mdx or files with ), only these fields are required:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] ---
- If any required fields are missing or empty, comment:
'This file appears to be missing required metadata. Please check keywords.config.yaml for valid options and add the required fields manually. You can validate your changes by running:pnpm validate-metadata ```'- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
pages/operators/chain-operators/management/blobs.mdxpages/notices/pectra-fees.mdx
🪛 LanguageTool
pages/notices/pectra-fees.mdx
[style] ~24-~24: Consider a more concise word here.
Context: ...e, so almost all chains make use of it. In order to continue to optimize for chains operati...
(IN_ORDER_TO_PREMIUM)
[formatting] ~24-~24: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...r of modern fee configurations unchanged, because it accounts for only the fixed intrinsi...
(COMMA_BEFORE_BECAUSE)
[grammar] ~26-~26: A verb may be missing after “It”. Please verify.
Context: ...xperience a reduction in profitability. It possible for such chains to be making a loss on ...
(PRP_JJ)
[uncategorized] ~26-~26: This verb may not be in the correct tense. Consider changing the tense to fit the context better.
Context: ...ability. It possible for such chains to be making a loss on data availabilty costs under ...
(AI_EN_LECTOR_REPLACEMENT_VERB_TENSE)
[uncategorized] ~26-~26: A comma may be missing after the conjunctive/linking adverb ‘Therefore’.
Context: ... costs under certain market conditions. Therefore all chains should check their fee scala...
(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
🔇 Additional comments (1)
pages/notices/pectra-fees.mdx (1)
45-45: Heading formatting is correctThe header “### Blob DA chains” follows sentence case and preserves the acronym. LGTM.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
pages/notices/pectra-fees.mdx (2)
24-24: Refine wording for conciseness and consistency.
- Replace “In order to continue to optimize” with “To continue optimizing”.
- Remove the comma before “because” to avoid an unnecessary pause.
- Avoid first-person “us”; use an impersonal construction.
Suggested diff:
-In order to continue to optimize for chains operating with blob DA, the Optimism protocol's current DA fee pricing formula has remained unchanged despite Pectra activating on Ethereum. This allowed us to leave the base fee scalar of modern fee configurations unchanged, because it accounts for only the fixed intrinsic gas cost of 21,000 of a blob transaction. +To continue optimizing for chains operating with blob DA, the Optimism protocol's current DA fee pricing formula has remained unchanged despite Pectra activating on Ethereum. This allows the base fee scalar of modern fee configurations to remain unchanged because it accounts for the fixed intrinsic gas cost (21,000) of a blob transaction.🧰 Tools
🪛 LanguageTool
[style] ~24-~24: Consider a more concise word here.
Context: ...e, so almost all chains make use of it. In order to continue to optimize for chains operati...(IN_ORDER_TO_PREMIUM)
[formatting] ~24-~24: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...r of modern fee configurations unchanged, because it accounts for only the fixed intrinsi...(COMMA_BEFORE_BECAUSE)
46-46: Nitpick: Improve punctuation and preposition.Add a comma after the introductory clause and adjust the preposition for smoother reading.
Suggested diff:
-Without such a change it is likely that you are overcharging users most of the time, and undercharging them in the rare occasions where blob DA is more expensive than calldata DA on Ethereum mainnet. +Without such a change, it is likely that you are overcharging users most of the time and undercharging them on the rare occasions when blob DA is more expensive than calldata DA on Ethereum mainnet.🧰 Tools
🪛 LanguageTool
[uncategorized] ~46-~46: A comma might be missing here.
Context: ...ately for using blob DA. Without such a change it is likely that you are overcharging ...(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~46-~46: The preposition “on” seems more likely in this position than the preposition “in”.
Context: ...ost of the time, and undercharging them in the rare occasions where blob DA is mor...(AI_EN_LECTOR_REPLACEMENT_PREPOSITION_IN_ON)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
pages/notices/pectra-fees.mdx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with the following criteria: - First, check the frontmatter section at the top of the file: 1. For regular pages, ensure AL...
**/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- First, check the frontmatter section at the top of the file:
- For regular pages, ensure ALL these fields are present and not empty:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] personas: [non-empty array] categories: [non-empty array] content_type: [valid type] ---
- For landing pages (index.mdx or files with ), only these fields are required:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] ---
- If any required fields are missing or empty, comment:
'This file appears to be missing required metadata. Please check keywords.config.yaml for valid options and add the required fields manually. You can validate your changes by running:pnpm validate-metadata ```'- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
pages/notices/pectra-fees.mdx
🪛 LanguageTool
pages/notices/pectra-fees.mdx
[style] ~24-~24: Consider a more concise word here.
Context: ...e, so almost all chains make use of it. In order to continue to optimize for chains operati...
(IN_ORDER_TO_PREMIUM)
[formatting] ~24-~24: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...r of modern fee configurations unchanged, because it accounts for only the fixed intrinsi...
(COMMA_BEFORE_BECAUSE)
[grammar] ~26-~26: A verb may be missing after “It”. Please verify.
Context: ...xperience a reduction in profitability. It possible for such chains to be making a loss on ...
(PRP_JJ)
[uncategorized] ~26-~26: This verb may not be in the correct tense. Consider changing the tense to fit the context better.
Context: ...ability. It possible for such chains to be making a loss on data availabilty costs under ...
(AI_EN_LECTOR_REPLACEMENT_VERB_TENSE)
[uncategorized] ~26-~26: A comma may be missing after the conjunctive/linking adverb ‘Therefore’.
Context: ... costs under certain market conditions. Therefore all chains should check their fee scala...
(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
[uncategorized] ~46-~46: A comma might be missing here.
Context: ...ately for using blob DA. Without such a change it is likely that you are overcharging ...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~46-~46: The preposition “on” seems more likely in this position than the preposition “in”.
Context: ...ost of the time, and undercharging them in the rare occasions where blob DA is mor...
(AI_EN_LECTOR_REPLACEMENT_PREPOSITION_IN_ON)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
🔇 Additional comments (5)
pages/notices/pectra-fees.mdx (5)
22-22: Approve descriptive clarity for EIP-7623.The change specifying “calldata-heavy transactions” improves precision and accurately reflects the intended scope.
32-32: Approve imperative call to action.The instruction “Please review your Ecotone scalar chain configuration” is clear, imperative, and correctly directs the reader’s next step.
34-36: Approve informational callout.The
<Callout type="info">block is used appropriately to highlight conditional guidance without personal pronouns and maintains a concise, imperative tone.
38-38: Approve H3 header styling.The header “Chains charging for calldata DA and spending on calldata DA” correctly uses sentence case and preserves acronyms/technical terms.
45-45: Approve H3 header styling.The header “Chains charging for calldata DA and spending on blob DA” consistently follows sentence-case conventions and handles acronyms properly.
|
We should update the google sheet with the magic value to fix calldata only chains. |
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
pages/notices/pectra-fees.mdx (1)
3-3:⚠️ Potential issueFix word choice in description frontmatter.
The noun "effect" should replace the verb "affect" to accurately describe the Pectra upgrade’s impact.
- description: L1 Pectra affect on user fees and chain profitability analysis + description: L1 Pectra effect on user fees and chain profitability analysis
🧹 Nitpick comments (4)
pages/notices/pectra-fees.mdx (4)
26-26: Refine punctuation and terminology.Remove the comma before "because", simplify "In order to continue…" to "To continue…", and standardize “OPStack” to “OP Stack” for consistency with branding.
- Blob DA has now been the default and recommended option for the OPStack for some time, so almost all chains make use of it. In order to continue to optimize for chains operating with blob DA, the Optimism protocol's current DA fee pricing formula has remained unchanged despite Pectra activating on Ethereum. This allowed us to leave the base fee scalar of modern fee configurations unchanged, because it accounts for only the fixed intrinsic gas cost of 21,000 of a blob transaction. + Blob DA has now been the default and recommended option for the OP Stack for some time, so almost all chains make use of it. To continue to optimize for chains operating with blob DA, the Optimism protocol's current DA fee pricing formula has remained unchanged despite Pectra activating on Ethereum. This allowed us to leave the base fee scalar of modern fee configurations unchanged because it accounts for only the fixed intrinsic gas cost of 21,000 of a blob transaction.🧰 Tools
🪛 LanguageTool
[style] ~26-~26: Consider a more concise word here.
Context: ...e, so almost all chains make use of it. In order to continue to optimize for chains operati...(IN_ORDER_TO_PREMIUM)
[formatting] ~26-~26: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...r of modern fee configurations unchanged, because it accounts for only the fixed intrinsi...(COMMA_BEFORE_BECAUSE)
43-43: Consider simplifying the scalar multiplier expression.Optionally, include the decimal equivalent for clarity (e.g., "scale by 2.5 (10/4)").
46-46: Fix missing comma and clarify preposition.Add a comma after "Without such a change" and change "in the rare occasions" to "on the rare occasions" for grammatical accuracy.
- Without such a change it is likely that you are overcharging users most of the time, and undercharging them in the rare occasions where blob DA is more expensive than calldata DA on Ethereum mainnet. + Without such a change, it is likely that you are overcharging users most of the time, and undercharging them on the rare occasions where blob DA is more expensive than calldata DA on Ethereum mainnet.🧰 Tools
🪛 LanguageTool
[uncategorized] ~46-~46: A comma might be missing here.
Context: ...ately for using blob DA. Without such a change it is likely that you are overcharging ...(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~46-~46: The preposition “on” seems more likely in this position than the preposition “in”.
Context: ...ost of the time, and undercharging them in the rare occasions where blob DA is mor...(AI_EN_LECTOR_REPLACEMENT_PREPOSITION_IN_ON)
49-49: Optional: Simplify concluding sentence.Consider tightening the wording for brevity. For example:
- As ever, you may continue to tweak the Ecotone scalars as desired in order to adjust the profitability of your chain. + As ever, you may tweak Ecotone scalars to adjust your chain’s profitability.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
pages/notices/pectra-fees.mdx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with the following criteria: - First, check the frontmatter section at the top of the file: 1. For regular pages, ensure AL...
**/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- First, check the frontmatter section at the top of the file:
- For regular pages, ensure ALL these fields are present and not empty:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] personas: [non-empty array] categories: [non-empty array] content_type: [valid type] ---
- For landing pages (index.mdx or files with ), only these fields are required:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] ---
- If any required fields are missing or empty, comment:
'This file appears to be missing required metadata. Please check keywords.config.yaml for valid options and add the required fields manually. You can validate your changes by running:pnpm validate-metadata ```'- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
pages/notices/pectra-fees.mdx
🪛 LanguageTool
pages/notices/pectra-fees.mdx
[style] ~26-~26: Consider a more concise word here.
Context: ...e, so almost all chains make use of it. In order to continue to optimize for chains operati...
(IN_ORDER_TO_PREMIUM)
[formatting] ~26-~26: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...r of modern fee configurations unchanged, because it accounts for only the fixed intrinsi...
(COMMA_BEFORE_BECAUSE)
[grammar] ~28-~28: A verb may be missing after “It”. Please verify.
Context: ...xperience a reduction in profitability. It possible for such chains to be making a loss on ...
(PRP_JJ)
[uncategorized] ~28-~28: This verb may not be in the correct tense. Consider changing the tense to fit the context better.
Context: ...ability. It possible for such chains to be making a loss on data availabilty costs under ...
(AI_EN_LECTOR_REPLACEMENT_VERB_TENSE)
[uncategorized] ~28-~28: A comma may be missing after the conjunctive/linking adverb ‘Therefore’.
Context: ... costs under certain market conditions. Therefore all chains should check their fee scala...
(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
[uncategorized] ~46-~46: A comma might be missing here.
Context: ...ately for using blob DA. Without such a change it is likely that you are overcharging ...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~46-~46: The preposition “on” seems more likely in this position than the preposition “in”.
Context: ...ost of the time, and undercharging them in the rare occasions where blob DA is mor...
(AI_EN_LECTOR_REPLACEMENT_PREPOSITION_IN_ON)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
🔇 Additional comments (7)
pages/notices/pectra-fees.mdx (7)
18-18: Confirm correct import placement forCallout.Importing
Calloutimmediately after frontmatter is standard and necessary for usage below. This looks correct.
24-24: Approve clarified EIP-7623 description.Specifying "calldata-heavy transactions" is more precise than "calldata transactions" and aligns with domain context.
34-34: Approve clear operator action link.The guidance to review Ecotone scalar configuration is clear, with a valid link to the relevant guide.
36-38: Approve informational callout structure.The
<Callout type="info">usage effectively highlights conditional advice for calldata-only chains.
40-40: Approve header sentence case for DA-specific actions.The H3 header uses proper sentence case and clearly describes the scenario.
41-41: Approve detailed action description.The instructions are precise and maintain consistent styling, including correct use of emphasis.
45-45: Approve header for blob DA scenario.Sentence case is applied correctly, and the section distinction is clear.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
pages/notices/pectra-fees.mdx (2)
26-26: Clarify unchanged DA fee formula for blob DA chains
This addition explains why blob DA chains don't require config updates post-Pectra.You might simplify "In order to continue to optimize for chains operating with blob DA" to "To continue optimizing for blob DA chains," for conciseness.
🧰 Tools
🪛 LanguageTool
[style] ~26-~26: Consider a more concise word here.
Context: ...e, so almost all chains make use of it. In order to continue to optimize for chains operati...(IN_ORDER_TO_PREMIUM)
41-41: Ensure clear instructions for profit margin review
Consider using a more descriptive link text instead of "[this guide]" to improve accessibility and maintain consistency.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
pages/notices/pectra-fees.mdx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with the following criteria: - First, check the frontmatter section at the top of the file: 1. For regular pages, ensure AL...
**/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- First, check the frontmatter section at the top of the file:
- For regular pages, ensure ALL these fields are present and not empty:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] personas: [non-empty array] categories: [non-empty array] content_type: [valid type] ---
- For landing pages (index.mdx or files with ), only these fields are required:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] ---
- If any required fields are missing or empty, comment:
'This file appears to be missing required metadata. Please check keywords.config.yaml for valid options and add the required fields manually. You can validate your changes by running:pnpm validate-metadata ```'- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
pages/notices/pectra-fees.mdx
🪛 LanguageTool
pages/notices/pectra-fees.mdx
[style] ~26-~26: Consider a more concise word here.
Context: ...e, so almost all chains make use of it. In order to continue to optimize for chains operati...
(IN_ORDER_TO_PREMIUM)
[grammar] ~28-~28: A verb may be missing after “It”. Please verify.
Context: ...xperience a reduction in profitability. It possible for such chains to be making a loss on ...
(PRP_JJ)
[uncategorized] ~28-~28: This verb may not be in the correct tense. Consider changing the tense to fit the context better.
Context: ...ability. It possible for such chains to be making a loss on data availabilty costs under ...
(AI_EN_LECTOR_REPLACEMENT_VERB_TENSE)
[uncategorized] ~28-~28: A comma may be missing after the conjunctive/linking adverb ‘Therefore’.
Context: ... costs under certain market conditions. Therefore all chains should check their fee scala...
(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
[uncategorized] ~46-~46: A comma might be missing here.
Context: ...ately for using blob DA. Without such a change it is likely that you are overcharging ...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~46-~46: The preposition “on” seems more likely in this position than the preposition “in”.
Context: ...ost of the time, and undercharging them in the rare occasions where blob DA is mor...
(AI_EN_LECTOR_REPLACEMENT_PREPOSITION_IN_ON)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
🔇 Additional comments (7)
pages/notices/pectra-fees.mdx (7)
18-18: ImportCalloutfrom Nextra for informational callouts
The added import enables rendering of the<Callout>component used later. Looks good.
24-24: Specify "calldata-heavy" for clarity
Updating to "calldata-heavy transactions" more accurately describes the use case.
34-34: Link to Ecotone scalar configuration guide
This imperative prompt clearly directs operators to review their scalar settings—good UX.
36-38: Add informational callout for zero blob base fee scalar chains
The<Callout>wraps the special case guidance nicely and improves readability.
40-40: Introduce section for calldata-only submission chains
The new heading correctly segments instructions for chains charging and spending on calldata DA.
43-43: Confirm scalar adjustment multiplier update
The new10/4ratio replaces the previous16/10. Please verify that this value aligns with the linked management guide and any other related docs.
45-45: Separate blob DA pricing instructions
This heading differentiates the blob DA scenario effectively.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
pages/notices/pectra-fees.mdx (4)
26-26: Use concise phrasing for optimizationConsider replacing “In order to continue to optimize for chains operating with blob DA” with a more concise alternative like “To continue optimizing for chains operating with blob DA,” to reduce wordiness.
🧰 Tools
🪛 LanguageTool
[style] ~26-~26: Consider a more concise word here.
Context: ...e, so almost all chains make use of it. In order to continue to optimize for chains operati...(IN_ORDER_TO_PREMIUM)
28-28: Add missing comma after conjunctive adverbInsert a comma after “Therefore” for proper punctuation:
-Therefore all chains should check their fee scalar config. +Therefore, all chains should check their fee scalar config.🧰 Tools
🪛 LanguageTool
[uncategorized] ~28-~28: A comma may be missing after the conjunctive/linking adverb ‘Therefore’.
Context: ... costs under certain market conditions. Therefore all chains should check their fee scala...(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
36-38: Clarify callout content punctuationWithin the info callout, add a comma after “Otherwise” and before “no action is necessary”:
-Otherwise, no action is necessary and the rest of this section does not apply. +Otherwise, no action is necessary, and the rest of this section does not apply.
45-47: Fix punctuation and preposition in guidanceIn the blob-DA guidance, add a comma after “Without such a change” and replace “in the rare occasions” with “on the rare occasions”:
-Doing so will ensure that you are charging accurately for using blob DA. Without such a change it is likely that you are overcharging users most of the time, and undercharging them in the rare occasions where blob DA is more expensive than calldata DA on Ethereum mainnet. +Doing so will ensure that you are charging accurately for using blob DA. Without such a change, it is likely that you are overcharging users most of the time, and undercharging them on the rare occasions when blob DA is more expensive than calldata DA on Ethereum mainnet.🧰 Tools
🪛 LanguageTool
[uncategorized] ~46-~46: A comma might be missing here.
Context: ...ately for using blob DA. Without such a change it is likely that you are overcharging ...(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~46-~46: The preposition “on” seems more likely in this position than the preposition “in”.
Context: ...ost of the time, and undercharging them in the rare occasions where blob DA is mor...(AI_EN_LECTOR_REPLACEMENT_PREPOSITION_IN_ON)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
pages/notices/pectra-fees.mdx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with the following criteria: - First, check the frontmatter section at the top of the file: 1. For regular pages, ensure AL...
**/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- First, check the frontmatter section at the top of the file:
- For regular pages, ensure ALL these fields are present and not empty:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] personas: [non-empty array] categories: [non-empty array] content_type: [valid type] ---
- For landing pages (index.mdx or files with ), only these fields are required:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] ---
- If any required fields are missing or empty, comment:
'This file appears to be missing required metadata. Please check keywords.config.yaml for valid options and add the required fields manually. You can validate your changes by running:pnpm validate-metadata ```'- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
pages/notices/pectra-fees.mdx
🪛 LanguageTool
pages/notices/pectra-fees.mdx
[style] ~26-~26: Consider a more concise word here.
Context: ...e, so almost all chains make use of it. In order to continue to optimize for chains operati...
(IN_ORDER_TO_PREMIUM)
[uncategorized] ~28-~28: A comma may be missing after the conjunctive/linking adverb ‘Therefore’.
Context: ... costs under certain market conditions. Therefore all chains should check their fee scala...
(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
[uncategorized] ~46-~46: A comma might be missing here.
Context: ...ately for using blob DA. Without such a change it is likely that you are overcharging ...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~46-~46: The preposition “on” seems more likely in this position than the preposition “in”.
Context: ...ost of the time, and undercharging them in the rare occasions where blob DA is mor...
(AI_EN_LECTOR_REPLACEMENT_PREPOSITION_IN_ON)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
🔇 Additional comments (4)
pages/notices/pectra-fees.mdx (4)
18-18: Import callout component correctlyThe import of
Calloutfromnextra/componentsis necessary and correctly placed immediately after the frontmatter. Good to go.
24-24: EIP-7623 description is clearThe updated phrasing correctly specifies “calldata-heavy transactions” and provides the proper context. No changes needed.
34-34: Ecotone scalar chain configuration instructionThe imperative instruction to review the Ecotone scalar configuration is clear and correctly linked. No changes needed.
40-43: Chains charging for calldata DA (calldata-only)The heading and instructions are clear, use proper sentence-case headers, and the guidance is structured well. No changes needed.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
pages/notices/pectra-fees.mdx (4)
26-26: Consider more concise phrasing
Use “To continue optimizing” instead of “In order to continue to optimize for” for brevity and flow:- In order to continue to optimize for chains operating with blob DA, the Optimism protocol's current DA fee pricing formula has remained unchanged despite Pectra activating on Ethereum. + To continue optimizing for chains operating with blob DA, the Optimism protocol's current DA fee pricing formula has remained unchanged despite Pectra activating on Ethereum.🧰 Tools
🪛 LanguageTool
[style] ~26-~26: Consider a more concise word here.
Context: ...e, so almost all chains make use of it. In order to continue to optimize for chains operati...(IN_ORDER_TO_PREMIUM)
28-28: Add comma after conjunctive adverb
A comma after “Therefore” will improve readability and adhere to style conventions:- Therefore all chains should check their fee scalar config. + Therefore, all chains should check their fee scalar config.🧰 Tools
🪛 LanguageTool
[uncategorized] ~28-~28: A comma may be missing after the conjunctive/linking adverb ‘Therefore’.
Context: ... costs under certain market conditions. Therefore all chains should check their fee scala...(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
41-41: Sentence length – optional split
This guidance is clear, but you may consider splitting into two sentences to improve readability for long paragraphs.
46-46: Add comma and refine preposition
Improve clarity by adding a comma after “Without such a change” and using “on” instead of “in” for “on the rare occasions”:- Without such a change it is likely that you are overcharging users most of the time, and undercharging them in the rare occasions where blob DA is more expensive than calldata DA on Ethereum mainnet. + Without such a change, it is likely that you are overcharging users most of the time, and undercharging them on the rare occasions where blob DA is more expensive than calldata DA on Ethereum mainnet.🧰 Tools
🪛 LanguageTool
[uncategorized] ~46-~46: A comma might be missing here.
Context: ...ately for using blob DA. Without such a change it is likely that you are overcharging ...(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~46-~46: The preposition “on” seems more likely in this position than the preposition “in”.
Context: ...ost of the time, and undercharging them in the rare occasions where blob DA is mor...(AI_EN_LECTOR_REPLACEMENT_PREPOSITION_IN_ON)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
pages/notices/pectra-fees.mdx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with the following criteria: - First, check the frontmatter section at the top of the file: 1. For regular pages, ensure AL...
**/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- First, check the frontmatter section at the top of the file:
- For regular pages, ensure ALL these fields are present and not empty:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] personas: [non-empty array] categories: [non-empty array] content_type: [valid type] ---
- For landing pages (index.mdx or files with ), only these fields are required:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] ---
- If any required fields are missing or empty, comment:
'This file appears to be missing required metadata. Please check keywords.config.yaml for valid options and add the required fields manually. You can validate your changes by running:pnpm validate-metadata ```'- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
pages/notices/pectra-fees.mdx
🪛 LanguageTool
pages/notices/pectra-fees.mdx
[style] ~26-~26: Consider a more concise word here.
Context: ...e, so almost all chains make use of it. In order to continue to optimize for chains operati...
(IN_ORDER_TO_PREMIUM)
[uncategorized] ~28-~28: A comma may be missing after the conjunctive/linking adverb ‘Therefore’.
Context: ... costs under certain market conditions. Therefore all chains should check their fee scala...
(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
[uncategorized] ~46-~46: A comma might be missing here.
Context: ...ately for using blob DA. Without such a change it is likely that you are overcharging ...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~46-~46: The preposition “on” seems more likely in this position than the preposition “in”.
Context: ...ost of the time, and undercharging them in the rare occasions where blob DA is mor...
(AI_EN_LECTOR_REPLACEMENT_PREPOSITION_IN_ON)
[style] ~48-~48: Consider a more concise word here.
Context: ...to tweak the Ecotone scalars as desired in order to adjust the profitability of your chain....
(IN_ORDER_TO_PREMIUM)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
🔇 Additional comments (9)
pages/notices/pectra-fees.mdx (9)
18-18: Add necessary MDX component import
ImportingCalloutis required for the informational callout later in the document.
24-24: Clarify impacted transaction types
Specifying “calldata-heavy transactions” sharpens the description and aligns precisely with EIP-7623’s scope.
34-34: Link to Ecotone scalar guide is clear
The directive to review the Ecotone scalar configuration is concise and properly formatted.
36-38: Verify MDX callout syntax
The<Callout>block appears correctly implemented. Ensure it renders as intended in the Nextra build.
40-40: Header style compliance
The H3 header uses sentence case and preserves the uppercase acronym “DA” appropriately.
43-43: Scaling factor updated correctly
The revised instruction to scale the base fee scalar by 10/4 accurately reflects the updated recommendation.
45-45: Header style compliance
The second H3 header correctly follows sentence case and technical naming conventions.
50-50: Technical references header
The “Technical references” section header uses sentence case appropriately and is clear.
52-54: Reference links formatting
The bulleted references are well-formatted. Please verify that each URL points to the correct spec or source code location.
Review comments here #1608