-
Notifications
You must be signed in to change notification settings - Fork 265
feat : add and update rpc-providers #1524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-optimism ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe pull request extends the documentation for RPC providers by introducing a new section called All That Node. This section outlines the details of a new RPC provider that supports high-performance and reliable RPC services. The content explains that the provider offers both full and archive nodes, available on the Optimism Mainnet and Sepolia Testnet. It includes subsections for "Description and pricing" and "Supported networks," outlining flexible access options through HTTPS and WebSocket protocols along with various plan types such as free, paid, and dedicated nodes. The changes add new informational content without affecting any existing functionality, logic, or features. Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pages/app-developers/tools/connect/rpc-providers.mdx (1)
54-64
: New "All That Node" Section – Adjust Pronoun UsageThe newly added section is structured well and clearly outlines the provider’s offerings, including details on full and archive nodes and supported networks. However, in line 58 the statement "We provide flexible access through HTTPS and WebSocket protocols…" uses first-person pronouns, which is not consistent with communal documentation guidelines. It is recommended to revise this sentence to a neutral, third-person tone. For example:
- [All That Node](https://www.allthatnode.com/protocol/optimism.dsrv) is a high-performance and reliable RPC provider offering full and archive nodes on both Optimism Mainnet and Sepolia Testnet. We provide flexible access through HTTPS and WebSocket protocols, supporting a wide range of use cases with free plans, paid plans, and dedicated nodes, perfect for developers and enterprises alike. + [All That Node](https://www.allthatnode.com/protocol/optimism.dsrv) is a high-performance and reliable RPC provider offering full and archive nodes on both Optimism Mainnet and Sepolia Testnet. It provides flexible access through HTTPS and WebSocket protocols, supporting a wide range of use cases with free plans, paid plans, and dedicated nodes, ideal for developers and enterprises alike.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pages/app-developers/tools/connect/rpc-providers.mdx
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with the following criteria: - First, check the frontmatter section at the top of the file: 1. For regular pages, ensure AL...
**/*.mdx
: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- First, check the frontmatter section at the top of the file:
- For regular pages, ensure ALL these fields are present and not empty:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] personas: [non-empty array] categories: [non-empty array] content_type: [valid type] ---
- For landing pages (index.mdx or files with ), only these fields are required:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] ---
- If any required fields are missing or empty, comment:
'This file appears to be missing required metadata. You can fix this by running:Review the changes, then run without :dry to apply them.'pnpm metadata-batch-cli:dry "path/to/this/file.mdx"
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
pages/app-developers/tools/connect/rpc-providers.mdx
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
🔇 Additional comments (1)
pages/app-developers/tools/connect/rpc-providers.mdx (1)
1-18
: Frontmatter and Metadata CheckThe frontmatter includes all the required fields (title, lang, description, topic, personas, categories, and content_type) and is properly formatted. No changes are required here.
Thanks for the feedback! I've updated the description to use a third-person tone as suggested. Let me know if there’s anything else to adjust! |
Description
This PR adds All That Node (https://allthatnode.com) to the list of node providers in the Optimism ecosystem documentation. It’s a reliable RPC service compatible with Optimism, offering developers an additional endpoint for building on the network.
Tests
No tests were added since this is a documentation update.
Additional context
All That Node is a trusted provider supporting multiple blockchains, and adding it to the Optimism docs will give developers more options for reliable node access, enhancing the ecosystem’s accessibility.
Metadata
None