Skip to content

Fixing the run node from source tutorial #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 6, 2025
Merged

Fixing the run node from source tutorial #1461

merged 4 commits into from
Mar 6, 2025

Conversation

sbvegan
Copy link
Collaborator

@sbvegan sbvegan commented Mar 6, 2025

Description

  • Updated the dependencies to reflect mise
  • Generalized the OP Mainnet/Sepolia tutorials to be one Superchain tutorial
  • Updated the redirects

Additional context

I did not reindex algolia/kapa

Metadata

@sbvegan sbvegan requested a review from a team as a code owner March 6, 2025 00:32
Copy link

netlify bot commented Mar 6, 2025

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit 8dbfe22
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/67c8ed0b0ff4390008f58c22
😎 Deploy Preview https://deploy-preview-1461--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Mar 6, 2025

📝 Walkthrough

Walkthrough

This pull request updates several documentation files related to node operator tutorials. The changes standardize naming conventions across the content, rebranding tutorials to focus on "Superchain" nodes. Specifically, tutorial titles and descriptions have been updated: "Running a Node With Docker" remains similar with minor formatting, while both "Building a Node From Source" and "Running an OP Mainnet/Sepolia Node from Source" are renamed to clearly reflect the Superchain focus. The dependency management and command instructions in the build tutorials have been simplified, and an outdated tutorial file has been removed. Additionally, new public redirect rules have been introduced so that legacy paths for mainnet and testnet tutorials now point to the consolidated Superchain node tutorial.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant WebServer
    User->>WebServer: Request /operators/node-operators/tutorials/mainnet
    WebServer-->>User: Redirect to /operators/node-operators/tutorials/run-node-from-source
    User->>WebServer: Request /operators/node-operators/tutorials/testnet
    WebServer-->>User: Redirect to /operators/node-operators/tutorials/run-node-from-source
Loading

Suggested labels

tutorial

Suggested reviewers

  • cpengilly

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (6)
pages/operators/node-operators/rollup-node.mdx (2)

34-34: Minor inconsistency in tutorial name.

The link text uses title case "Building a Node from Source" while the actual tutorial is named "Building a Superchain node from source". This inconsistency could confuse users.

-  *   **Option 2:** Follow the [Building a Node from Source](/operators/node-operators/tutorials/node-from-source) tutorial, if you need to use a specific architecture or want to inspect the source code of your OP Stack rollup node.
+  *   **Option 2:** Follow the [Building a Superchain node from source](/operators/node-operators/tutorials/node-from-source) tutorial, if you need to use a specific architecture or want to inspect the source code of your OP Stack rollup node.

50-51: Add missing comma in the snap sync recommendation.

A comma should be added after "but" for proper sentence structure.

-  *   Enable [snap sync](/operators/node-operators/management/snap-sync) for your node to significantly improve the experience and speed of syncing an OP Stack node.
-      This is an **optional** feature but highly recommended for node providers.
+  *   Enable [snap sync](/operators/node-operators/management/snap-sync) for your node to significantly improve the experience and speed of syncing an OP Stack node.
+      This is an **optional** feature, but highly recommended for node providers.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~51-~51: Possible missing comma found.
Context: ...e. This is an optional feature but highly recommended for node providers. ...

(AI_HYDRA_LEO_MISSING_COMMA)

pages/operators/node-operators/tutorials/node-from-source.mdx (1)

1-5: Metadata completeness in frontmatter.
The frontmatter only includes title, lang, and description. For a regular page, the guidelines require additional fields such as topic, personas, categories, and content_type to be present and non‐empty. Please update the metadata accordingly.

pages/operators/node-operators/tutorials/run-node-from-source.mdx (3)

1-5: Metadata completeness in frontmatter.
The frontmatter contains title, lang, and description only. For a standard documentation page, please add the required fields: topic, personas, categories, and content_type to meet our documentation standards.


9-13: Introduction text terminology check.
The introduction now explains how to run an “OP Stack node from source code” for full and archive nodes. Please verify whether “OP Stack node” is the intended term or if it should be updated to “Superchain node” for consistency with the new branding.


19-24: Hardware requirements section terminology consistency.
The “Hardware requirements” text refers to “OP Mainnet nodes.” Since the overall tutorial now focuses on Superchain nodes (with full nodes rebranded as “Superchain nodes”), consider verifying whether this section should also be updated for consistency or if it intentionally distinguishes full nodes from archive nodes.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 02a18c7 and 8dbfe22.

📒 Files selected for processing (7)
  • pages/operators/node-operators/rollup-node.mdx (5 hunks)
  • pages/operators/node-operators/tutorials.mdx (1 hunks)
  • pages/operators/node-operators/tutorials/_meta.json (1 hunks)
  • pages/operators/node-operators/tutorials/node-from-source.mdx (4 hunks)
  • pages/operators/node-operators/tutorials/run-node-from-source.mdx (7 hunks)
  • pages/operators/node-operators/tutorials/testnet.mdx (0 hunks)
  • public/_redirects (1 hunks)
💤 Files with no reviewable changes (1)
  • pages/operators/node-operators/tutorials/testnet.mdx
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with ...

**/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • First, check the frontmatter section at the top of the file:
    1. For regular pages, ensure ALL these fields are present and not empty:
    ---
    title: [non-empty]
    lang: [non-empty]
    description: [non-empty]
    topic: [non-empty]
    personas: [non-empty array]
    categories: [non-empty array]
    content_type: [valid type]
    ---
    1. For landing pages (index.mdx or files with ), only these fields are required:
    ---
    title: [non-empty]
    lang: [non-empty]
    description: [non-empty]
    topic: [non-empty]
    ---
    1. If any required fields are missing or empty, comment:
      'This file appears to be missing required metadata. You can fix this by running:
    pnpm metadata-batch-cli:dry "path/to/this/file.mdx"
    Review the changes, then run without :dry to apply them.'
  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
  • pages/operators/node-operators/tutorials.mdx
  • pages/operators/node-operators/tutorials/node-from-source.mdx
  • pages/operators/node-operators/tutorials/run-node-from-source.mdx
  • pages/operators/node-operators/rollup-node.mdx
🪛 LanguageTool
pages/operators/node-operators/rollup-node.mdx

[uncategorized] ~51-~51: Possible missing comma found.
Context: ...e. This is an optional feature but highly recommended for node providers. ...

(AI_HYDRA_LEO_MISSING_COMMA)

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - docs-optimism
  • GitHub Check: Header rules - docs-optimism
  • GitHub Check: Pages changed - docs-optimism
🔇 Additional comments (16)
public/_redirects (1)

80-81: Proper implementation of redirects for consolidated tutorials.

These new redirects appropriately channel mainnet and testnet tutorial paths to the consolidated Superchain node tutorial, maintaining user accessibility during this documentation reorganization.

pages/operators/node-operators/tutorials/_meta.json (1)

3-4: Superchain branding consistently applied to tutorial entries.

The terminology updates in the metadata properly align with the PR objective of standardizing the Superchain terminology across node operation documentation. The new "run-node-from-source" entry corresponds to the redirects established in _redirects file.

pages/operators/node-operators/tutorials.mdx (2)

13-13: Introduction text properly updated for consolidated approach.

The new introduction text clearly explains the documentation scope, successfully generalizing the content to focus on Superchain networks rather than specific implementations.


18-20: Card titles properly updated to reflect Superchain focus.

The card titles now consistently use "Superchain" branding and include the new "Running a Superchain node from source" tutorial that replaces the previous network-specific tutorials.

pages/operators/node-operators/rollup-node.mdx (4)

65-65: Clear instruction for running a Superchain node.

The text now properly references "Superchain network" instead of specific networks, aligning with the PR objective of standardizing terminology.


71-72: Successfully consolidated network-specific tutorials.

Both OP Sepolia and OP Mainnet tutorial options now point to the same "Running a Superchain node from source" tutorial, successfully implementing the PR objective of generalizing tutorials.


94-94: Consistent Superchain terminology usage.

The warning message now correctly references "Superchain" instead of specific networks, maintaining consistency with the broader documentation update.


116-120: Tutorial table properly updated with Superchain terminology.

The tutorial table formatting has been improved and the names have been updated to consistently use "Superchain" terminology across all entries, aligning with the PR objectives.

pages/operators/node-operators/tutorials/node-from-source.mdx (4)

2-2: Title update verification.
The title has been updated to “Building a Superchain node from source” which aligns with the new branding.


9-9: Section header update verification.
The H1 header now reads “Building a Superchain node from source,” which is consistent with the updated title.


44-44: Dependency management section update.
The dependency section now describes the build environment managed via [mise]. This change simplifies dependency management by removing hard-coded version requirements.


155-155: Navigation link update verification.
The “Next steps” link now points to the “Run a Superchain node from source code” page. This update reflects the rebranding and ensures consistent navigation.

pages/operators/node-operators/tutorials/run-node-from-source.mdx (4)

2-4: Title and description update verification.
The title (“Running a Superchain node from source”) and description have been updated to reflect the new focus. These changes align with the rebranding objectives.


42-43: Section header for full nodes update verification.
The header “## Superchain nodes” correctly rebrands the full node section.


107-107: Updated configuration flag for op-geth.
The command now uses --op-network=op-sepolia instead of --op-network=op-mainnet, reflecting the updated network configuration.


164-164: Updated configuration flag for op-node.
The op-node startup command now includes --network=op-sepolia as part of the updated parameters, ensuring consistency with the new instructions.

@sbvegan sbvegan merged commit 713dcba into main Mar 6, 2025
8 checks passed
@sbvegan sbvegan deleted the sb/node-from-source branch March 6, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants