reOpen - Add XRPL EVM Sidechain configuration and update xrplevm icon metadata
#7507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review. |
|
Hi @Ahz9619 PR is up to date and with all checks passed. Can you review and approve please 🙏 |
|
Heyy please can someone review this PR. |
|
Hey @Ahz9619 please review and merge if ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title:
Add XRPL EVM Sidechain configuration and update
xrplevmicon metadataPull Request Description:
This PR introduces support for the XRPL EVM Sidechain (chainId 1440000) by adding a new network configuration file and updates the corresponding icon metadata.
An exact version of this PR had been made but got forgotten down in the list. I have closed the previous forgetten PR and opened this one again.
Please check and merge as viem and metamask are waiting on this PR to be merged.
Added
_data/chains/eip155-1440000.json(24 lines)chainIdandnetworkIdto 1440000https://rpc.xrplevm.org,https://ws.xrplevm.org)https://explorer.xrplevm.orgModified
_data/icons/xrplevm.json(3 additions, 3 deletions)ipfs://reference remain consistentNo deletions of existing network entries; purely additive configuration and minor icon adjustments.
Testing & Validation:
Feel free to review and suggest any further tweaks!