raft: next index shall be larger than match index.#149
Merged
Conversation
joshuazh-x
force-pushed
the
msgapp-index
branch
from
5015245 to
d021d56
Compare
pav-kv
approved these changes
Feb 2, 2024
Contributor
pav-kv
left a comment
pav-kv
left a comment
There was a problem hiding this comment.
LGTM % a couple minor things
joshuazh-x
force-pushed
the
msgapp-index
branch
from
d021d56 to
3637abd
Compare
Contributor
|
@joshuazh-x Thanks for the fix. @ahrtr Could you review/merge? Thank you. |
Member
|
LGTM with one nit. Confirmed that the test case will fail without the fix. Probably we should add an invariant check each time when sending a MsgApp message to ensure that the index should always be greater than the Match. It can be addressed in a separate PR. |
ahrtr
reviewed
Feb 4, 2024
joshuazh-x
force-pushed
the
msgapp-index
branch
from
3637abd to
1d00042
Compare
Member
|
Please rebase this PR although github doesn't show any conflict. |
Leader shall always replicate its log from a index larger than corresponding match index. Note that this is not a correctness issue, but rather an optimization in case of message reordering. Signed-off-by: Joshua Zhang <joshuazh@microsoft.com>
joshuazh-x
force-pushed
the
msgapp-index
branch
from
1d00042 to
6439482
Compare
Contributor
Author
done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leader shall always replicate its log from a index larger than corresponding match index. Note that this is not a correctness issue, but rather an optimization in case of message reordering.
Related: #148