Skip to content

[release-3.7] Set a 5-minutes ReadHeaderTimeout for client http.Server#22143

Merged
ahrtr merged 1 commit into
etcd-io:release-3.7from
k8s-infra-cherrypick-robot:cherry-pick-22128-to-release-3.7
Jul 22, 2026
Merged

[release-3.7] Set a 5-minutes ReadHeaderTimeout for client http.Server#22143
ahrtr merged 1 commit into
etcd-io:release-3.7from
k8s-infra-cherrypick-robot:cherry-pick-22128-to-release-3.7

Conversation

@k8s-infra-cherrypick-robot

Copy link
Copy Markdown

This is an automated cherry-pick of #22128

/assign ahrtr

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@kubernetes-prow

Copy link
Copy Markdown

Hi @k8s-infra-cherrypick-robot. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahrtr

ahrtr commented Jul 21, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.74%. Comparing base (7a4b47b) to head (ca6c06e).
⚠️ Report is 2 commits behind head on release-3.7.

Additional details and impacted files
Files with missing lines Coverage Δ
server/embed/serve.go 59.25% <100.00%> (+0.27%) ⬆️

... and 13 files with indirect coverage changes

@@               Coverage Diff               @@
##           release-3.7   #22143      +/-   ##
===============================================
+ Coverage        69.67%   69.74%   +0.06%     
===============================================
  Files              449      449              
  Lines            38186    38188       +2     
===============================================
+ Hits             26606    26634      +28     
+ Misses           10148    10125      -23     
+ Partials          1432     1429       -3     

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a4b47b...ca6c06e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ahrtr

ahrtr commented Jul 22, 2026

Copy link
Copy Markdown
Member

/retest

@kubernetes-prow

kubernetes-prow Bot commented Jul 22, 2026

Copy link
Copy Markdown

@k8s-infra-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-grpcproxy-e2e-amd64 ca6c06e link true /test pull-etcd-grpcproxy-e2e-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ahrtr

ahrtr commented Jul 22, 2026

Copy link
Copy Markdown
Member

/test pull-etcd-grpcproxy-integration-arm64

@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, k8s-infra-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr
ahrtr merged commit a63bc45 into etcd-io:release-3.7 Jul 22, 2026
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants