Update ConfigureCRLVerification to use callback VerifyConnection#22023
Conversation
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files
... and 19 files with indirect coverage changes @@ Coverage Diff @@
## main #22023 +/- ##
==========================================
+ Coverage 69.71% 69.75% +0.04%
==========================================
Files 449 449
Lines 38181 38177 -4
==========================================
+ Hits 26616 26631 +15
+ Misses 10136 10120 -16
+ Partials 1429 1426 -3 Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
enhance #22007
VerifyConnectionis the better fit here. It provides atls.ConnectionStatewithPeerCertificatesalready parsed, socheckCRLcan be called directly without the manualx509.ParseCertificateloop currently needed to turn rawCerts back into *x509.Certificate. This is the main simplification. It's also more robust because VerifyPeerCertificate isn't called for some cases.