Skip to content

Update ConfigureCRLVerification to use callback VerifyConnection#22023

Merged
ahrtr merged 1 commit into
etcd-io:mainfrom
ahrtr:20260701_crl
Jul 1, 2026
Merged

Update ConfigureCRLVerification to use callback VerifyConnection#22023
ahrtr merged 1 commit into
etcd-io:mainfrom
ahrtr:20260701_crl

Conversation

@ahrtr

@ahrtr ahrtr commented Jul 1, 2026

Copy link
Copy Markdown
Member

enhance #22007

VerifyConnection is the better fit here. It provides a tls.ConnectionState with PeerCertificates already parsed, so checkCRL can be called directly without the manual x509.ParseCertificate loop currently needed to turn rawCerts back into *x509.Certificate. This is the main simplification. It's also more robust because VerifyPeerCertificate isn't called for some cases.

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.75%. Comparing base (503a88f) to head (e84205a).

Files with missing lines Patch % Lines
client/pkg/transport/listener_tls.go 0.00% 6 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
client/pkg/transport/listener_tls.go 63.41% <0.00%> (+1.50%) ⬆️

... and 19 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #22023      +/-   ##
==========================================
+ Coverage   69.71%   69.75%   +0.04%     
==========================================
  Files         449      449              
  Lines       38181    38177       -4     
==========================================
+ Hits        26616    26631      +15     
+ Misses      10136    10120      -16     
+ Partials     1429     1426       -3     

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 503a88f...e84205a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr
ahrtr merged commit b7e426c into etcd-io:main Jul 1, 2026
34 checks passed
@ahrtr
ahrtr deleted the 20260701_crl branch July 1, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants