[App Loader] Deletes app before confirmation is selected

[RKBoss6]

Affected hardware version

Bangle 2, Bangle 1

Your firmware version

2v27

The bug

In the App Loader, when deleting an app, a confirmation window pops up, but also deletes the app, before user inputs confirmation. Can be harmful if the delete button for an app is accidentally pressed, as confirmation does not work.

Installed apps

No response

[RKBoss6]

If someone tells me what file the delete app function is in, or what functions are used for deleting an app, I can try to fix this.

[stweedo]

I did a little searching and found removeApp in index.js. It seems that startOperation is being ran before it should be, causing it to delete the app right away.

/** Prompt user and then remove app from the device */
function removeApp(app) {
  return showPrompt("Delete","Really remove '"+app.name+"'?")
    .then(() =>
    startOperation({ name: "Remove App" }, () => getInstalledApps())
      .then(()=> Comms.removeApp(device.appsInstalled.find(a => a.id === app.id))) // a = from appid.info, app = from apps.json
      .then(()=>{
        device.appsInstalled = device.appsInstalled.filter(a=>a.id!=app.id);
        showToast(app.name+" removed successfully","success");
      }, err=>{
        showToast(app.name+" removal failed, "+err,"error");
      }));
}

This version waits for the prompt before starting the operation, and it gives startOperation the direct promise it expects from getInstalledApps().

I tested this and it seems to work, but there may be a better way that @gfwilliams would prefer.

[gfwilliams]

Thanks! Well spotted! Just merged and made this live - I made a minor tweak to bracketing because ideally we want the entire operation to be inside startOperation, rather than after it.

Sorry about that - that's a regression from the recent code that tries to stop operations from overlapping.