Skip to content

ArduinoOTA upload intermittent failure fixed #4657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 31, 2024
Merged

ArduinoOTA upload intermittent failure fixed #4657

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
75c3d2d
OTA upload often fails when client.read() return -1 and we subsequent…
Dec 25, 2020
9fbe842
Merge branch 'master' into master
lucasssvaz Jan 24, 2024
4a5b31d
Delay of 1ms already solves the issue
lucasssvaz Jan 25, 2024
13d61f5
Update libraries/ArduinoOTA/src/ArduinoOTA.cpp
lucasssvaz Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions libraries/ArduinoOTA/src/ArduinoOTA.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,10 @@ void ArduinoOTAClass::_runUpdate() {
size_t r = client.read(buf, available);
if(r != available){
log_w("didn't read enough! %u != %u", r, available);
if((int32_t) r<0){
delay(1);
continue; //let's not try to write 4 gigabytes when client.read returns -1
}
}

written = Update.write(buf, r);
Expand Down