Skip to content

Conversation

TKDev7
Copy link
Contributor

@TKDev7 TKDev7 commented Jun 23, 2025

Prerequisites checklist

What is the purpose of this pull request?

Add a new rule, no-reference-like-url, to disallow inline links or images when the URL matches a defined reference identifier.

What changes did you make? (Give an overview)

Implemented the no-reference-like-url rule with autofix, added documentation, and included tests.

Related Issues

Fixes #419

Is there anything you'd like reviewers to focus on?

snitin315
snitin315 previously approved these changes Jun 26, 2025
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Leaving it open for 2nd review.

@snitin315 snitin315 added this to Triage Jun 26, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jun 26, 2025
@snitin315 snitin315 moved this from Needs Triage to Second Review Needed in Triage Jun 26, 2025
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! No requests from me that aren't already noted. Thanks! 🚀

@TKDev7 TKDev7 dismissed stale reviews from JoshuaKGoldberg and snitin315 via a5272a5 June 27, 2025 07:17
@nzakas
Copy link
Member

nzakas commented Jul 11, 2025

@lumirlumir please take a look at the responses to your comments.

Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on my end. I've responded to your previous comment.

Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements! I’ve left a few comments about some other cases that are missing.

@lumirlumir lumirlumir changed the title feat: add no-reference-like-url rule feat: add no-reference-like-urls rule Aug 4, 2025
lumirlumir
lumirlumir previously approved these changes Aug 5, 2025
Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Would like @snitin315 to verify the changes before merging.

Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following case doesn't report any errors, is this expected behavior?

<!-- eslint markdown/no-reference-like-urls: "error" -->

[Mercury](  mercury) is the first planet from the sun.

[mercury]: https://example.com/mercury/

@TKDev7
Copy link
Contributor Author

TKDev7 commented Aug 11, 2025

@snitin315 This should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Second Review Needed
Development

Successfully merging this pull request may close these issues.

New Rule: no-reference-like-url
5 participants