-
Notifications
You must be signed in to change notification settings - Fork 76
feat: add no-reference-like-urls rule #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks. Leaving it open for 2nd review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! No requests from me that aren't already noted. Thanks! 🚀
@lumirlumir please take a look at the responses to your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay on my end. I've responded to your previous comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvements! I’ve left a few comments about some other cases that are missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Would like @snitin315 to verify the changes before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following case doesn't report any errors, is this expected behavior?
<!-- eslint markdown/no-reference-like-urls: "error" -->
[Mercury]( mercury) is the first planet from the sun.
[mercury]: https://example.com/mercury/
@snitin315 This should be fixed now. |
Prerequisites checklist
What is the purpose of this pull request?
Add a new rule, no-reference-like-url, to disallow inline links or images when the URL matches a defined reference identifier.
What changes did you make? (Give an overview)
Implemented the no-reference-like-url rule with autofix, added documentation, and included tests.
Related Issues
Fixes #419
Is there anything you'd like reviewers to focus on?