Skip to content
This repository was archived by the owner on Dec 4, 2018. It is now read-only.

Breaking: drop support for Node < 6 #223

Merged
merged 2 commits into from
Nov 10, 2018
Merged

Breaking: drop support for Node < 6 #223

merged 2 commits into from
Nov 10, 2018

Conversation

kaicataldo
Copy link
Member

@kaicataldo kaicataldo commented Nov 7, 2018 •
edited
Loading

refs eslint/tsc-meetings#107 (comment)

Is there anything else that I'm missing here?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.258% when pulling 9b3e2fc on travis-node-versions-update into a05e9f2 on master.

@coveralls
Copy link

coveralls commented Nov 7, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 99.258% when pulling 939eb7f on travis-node-versions-update into a05e9f2 on master.

@kaicataldo kaicataldo added chore and removed triage labels Nov 7, 2018
@kaicataldo
Chore: add supported Node.js versions to CI
939eb7f 
Wanted to add Node v11 to the list of versions in CI and noticed a few others were missing. Do we want to drop support for Node@<6 at some point?
@kaicataldo kaicataldo force-pushed the travis-node-versions-update branch from 9b3e2fc to 939eb7f Compare November 9, 2018 02:52
@kaicataldo kaicataldo changed the title Chore: add supported Node.js versions to CI Breaking: drop support for Node < 6 Nov 9, 2018
mysticatea
mysticatea approved these changes Nov 9, 2018
View reviewed changes
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@platinumazure platinumazure mentioned this pull request Nov 9, 2018
Closed
btmills
btmills reviewed Nov 9, 2018
View reviewed changes
package.json
@@ -5,7 +5,7 @@
"main": "lib/doctrine.js",
"version": "2.1.0",
"engines": {
"node": ">=0.10.0"
"node": ">=6.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't support Node 7, for example, would it make sense to make this line similar to that for ESLint?

https://github.com/eslint/eslint/blob/3dd7493a1e6a345ff82d9e5ed5ca797395f349bb/package.json#L126

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it matters in this context. If we are going to deprecate the entire module, might as well keep things simple.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

nzakas
nzakas approved these changes Nov 9, 2018
View reviewed changes
package.json
@@ -5,7 +5,7 @@
"main": "lib/doctrine.js",
"version": "2.1.0",
"engines": {
"node": ">=0.10.0"
"node": ">=6.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it matters in this context. If we are going to deprecate the entire module, might as well keep things simple.

btmills
btmills approved these changes Nov 9, 2018
View reviewed changes
Copy link
Member

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

package.json
@@ -5,7 +5,7 @@
"main": "lib/doctrine.js",
"version": "2.1.0",
"engines": {
"node": ">=0.10.0"
"node": ">=6.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

@kaicataldo kaicataldo merged commit 0b5a8c7 into master Nov 10, 2018
@kaicataldo kaicataldo deleted the travis-node-versions-update branch November 10, 2018 02:31
goto-bus-stop pushed a commit to u-wave/react-youtube that referenced this pull request Nov 13, 2018
@greenkeeper @goto-bus-stop
Update doctrine to the latest version 🚀 (#59)
1fe24ab 
## The devDependency [doctrine](https://github.com/eslint/doctrine) was updated from `2.1.0` to `3.0.0`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

---

<details>
<summary>Release Notes for v3.0.0</summary>

<ul>
<li><a class="commit-link" href="https://urls.greenkeeper.io/eslint/doctrine/commit/0b5a8c78824798ded2329001723886e8269da08d"><tt>0b5a8c7</tt></a> Breaking: drop support for Node &lt; 6 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="378433675" data-permission-text="Issue title is private" data-url="eslint/doctrine#223" data-hovercard-type="pull_request" data-hovercard-url="/eslint/doctrine/pull/223/hovercard" href="https://urls.greenkeeper.io/eslint/doctrine/pull/223">#223</a>) (Kai Cataldo)</li>
<li><a class="commit-link" href="https://urls.greenkeeper.io/eslint/doctrine/commit/a05e9f270dcb31c12999e1e5b6bac0335d904821"><tt>a05e9f2</tt></a> Upgrade: [email protected] (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="371258798" data-permission-text="Issue title is private" data-url="eslint/doctrine#220" data-hovercard-type="pull_request" data-hovercard-url="/eslint/doctrine/pull/220/hovercard" href="https://urls.greenkeeper.io/eslint/doctrine/pull/220">#220</a>) (Teddy Katz)</li>
<li><a class="commit-link" href="https://urls.greenkeeper.io/eslint/doctrine/commit/36ed02794b7d65339366f77a6f90892eadeee6cf"><tt>36ed027</tt></a> Chore: upgrade coveralls to ^3.0.1 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="325899308" data-permission-text="Issue title is private" data-url="eslint/doctrine#213" data-hovercard-type="pull_request" data-hovercard-url="/eslint/doctrine/pull/213/hovercard" href="https://urls.greenkeeper.io/eslint/doctrine/pull/213">#213</a>) (Teddy Katz)</li>
<li><a class="commit-link" href="https://urls.greenkeeper.io/eslint/doctrine/commit/8667e34a3ecf377d119d1dab4376c8be71fd95bf"><tt>8667e34</tt></a> Upgrade: eslint-release@^0.11.1 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="310208286" data-permission-text="Issue title is private" data-url="eslint/doctrine#210" data-hovercard-type="pull_request" data-hovercard-url="/eslint/doctrine/pull/210/hovercard" href="https://urls.greenkeeper.io/eslint/doctrine/pull/210">#210</a>) (Kevin Partington)</li>
</ul>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 6 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/eslint/doctrine/commit/42434ca1f85b264a88afcfd317487a7417e6004b"><code>42434ca</code></a> <code>3.0.0</code></li>
<li><a href="https://urls.greenkeeper.io/eslint/doctrine/commit/9655671fb175decb8f3969f3442aec4fad4922d6"><code>9655671</code></a> <code>Build: changelog update for 3.0.0</code></li>
<li><a href="https://urls.greenkeeper.io/eslint/doctrine/commit/0b5a8c78824798ded2329001723886e8269da08d"><code>0b5a8c7</code></a> <code>Breaking: drop support for Node &lt; 6 (#223)</code></li>
<li><a href="https://urls.greenkeeper.io/eslint/doctrine/commit/a05e9f270dcb31c12999e1e5b6bac0335d904821"><code>a05e9f2</code></a> <code>Upgrade: [email protected] (#220)</code></li>
<li><a href="https://urls.greenkeeper.io/eslint/doctrine/commit/36ed02794b7d65339366f77a6f90892eadeee6cf"><code>36ed027</code></a> <code>Chore: upgrade coveralls to ^3.0.1 (#213)</code></li>
<li><a href="https://urls.greenkeeper.io/eslint/doctrine/commit/8667e34a3ecf377d119d1dab4376c8be71fd95bf"><code>8667e34</code></a> <code>Upgrade: eslint-release@^0.11.1 (#210)</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/eslint/doctrine/compare/fdd0004782f218c4362fd928d82ef0e84a8e64d3...42434ca1f85b264a88afcfd317487a7417e6004b">full diff</a></p>
</details>

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴
goto-bus-stop pushed a commit to u-wave/react-dailymotion that referenced this pull request Nov 13, 2018
@greenkeeper @goto-bus-stop
Update doctrine to the latest version 🚀 (#120)
1e0cdd1 
## The devDependency [doctrine](https://github.com/eslint/doctrine) was updated from `2.1.0` to `3.0.0`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

---

<details>
<summary>Release Notes for v3.0.0</summary>

<ul>
<li><a class="commit-link" href="https://urls.greenkeeper.io/eslint/doctrine/commit/0b5a8c78824798ded2329001723886e8269da08d"><tt>0b5a8c7</tt></a> Breaking: drop support for Node &lt; 6 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="378433675" data-permission-text="Issue title is private" data-url="eslint/doctrine#223" data-hovercard-type="pull_request" data-hovercard-url="/eslint/doctrine/pull/223/hovercard" href="https://urls.greenkeeper.io/eslint/doctrine/pull/223">#223</a>) (Kai Cataldo)</li>
<li><a class="commit-link" href="https://urls.greenkeeper.io/eslint/doctrine/commit/a05e9f270dcb31c12999e1e5b6bac0335d904821"><tt>a05e9f2</tt></a> Upgrade: [email protected] (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="371258798" data-permission-text="Issue title is private" data-url="eslint/doctrine#220" data-hovercard-type="pull_request" data-hovercard-url="/eslint/doctrine/pull/220/hovercard" href="https://urls.greenkeeper.io/eslint/doctrine/pull/220">#220</a>) (Teddy Katz)</li>
<li><a class="commit-link" href="https://urls.greenkeeper.io/eslint/doctrine/commit/36ed02794b7d65339366f77a6f90892eadeee6cf"><tt>36ed027</tt></a> Chore: upgrade coveralls to ^3.0.1 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="325899308" data-permission-text="Issue title is private" data-url="eslint/doctrine#213" data-hovercard-type="pull_request" data-hovercard-url="/eslint/doctrine/pull/213/hovercard" href="https://urls.greenkeeper.io/eslint/doctrine/pull/213">#213</a>) (Teddy Katz)</li>
<li><a class="commit-link" href="https://urls.greenkeeper.io/eslint/doctrine/commit/8667e34a3ecf377d119d1dab4376c8be71fd95bf"><tt>8667e34</tt></a> Upgrade: eslint-release@^0.11.1 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="310208286" data-permission-text="Issue title is private" data-url="eslint/doctrine#210" data-hovercard-type="pull_request" data-hovercard-url="/eslint/doctrine/pull/210/hovercard" href="https://urls.greenkeeper.io/eslint/doctrine/pull/210">#210</a>) (Kevin Partington)</li>
</ul>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 6 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/eslint/doctrine/commit/42434ca1f85b264a88afcfd317487a7417e6004b"><code>42434ca</code></a> <code>3.0.0</code></li>
<li><a href="https://urls.greenkeeper.io/eslint/doctrine/commit/9655671fb175decb8f3969f3442aec4fad4922d6"><code>9655671</code></a> <code>Build: changelog update for 3.0.0</code></li>
<li><a href="https://urls.greenkeeper.io/eslint/doctrine/commit/0b5a8c78824798ded2329001723886e8269da08d"><code>0b5a8c7</code></a> <code>Breaking: drop support for Node &lt; 6 (#223)</code></li>
<li><a href="https://urls.greenkeeper.io/eslint/doctrine/commit/a05e9f270dcb31c12999e1e5b6bac0335d904821"><code>a05e9f2</code></a> <code>Upgrade: [email protected] (#220)</code></li>
<li><a href="https://urls.greenkeeper.io/eslint/doctrine/commit/36ed02794b7d65339366f77a6f90892eadeee6cf"><code>36ed027</code></a> <code>Chore: upgrade coveralls to ^3.0.1 (#213)</code></li>
<li><a href="https://urls.greenkeeper.io/eslint/doctrine/commit/8667e34a3ecf377d119d1dab4376c8be71fd95bf"><code>8667e34</code></a> <code>Upgrade: eslint-release@^0.11.1 (#210)</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/eslint/doctrine/compare/fdd0004782f218c4362fd928d82ef0e84a8e64d3...42434ca1f85b264a88afcfd317487a7417e6004b">full diff</a></p>
</details>

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴
goto-bus-stop pushed a commit to goto-bus-stop/react-abstract-autocomplete that referenced this pull request Nov 13, 2018
@greenkeeper @goto-bus-stop
Update doctrine to the latest version 🚀 (#158)
8401b1a 
## The devDependency [doctrine](https://github.com/eslint/doctrine) was updated from `2.1.0` to `3.0.0`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

---

<details>
<summary>Release Notes for v3.0.0</summary>

<ul>
<li><a class="commit-link" href="https://urls.greenkeeper.io/eslint/doctrine/commit/0b5a8c78824798ded2329001723886e8269da08d"><tt>0b5a8c7</tt></a> Breaking: drop support for Node &lt; 6 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="378433675" data-permission-text="Issue title is private" data-url="eslint/doctrine#223" data-hovercard-type="pull_request" data-hovercard-url="/eslint/doctrine/pull/223/hovercard" href="https://urls.greenkeeper.io/eslint/doctrine/pull/223">#223</a>) (Kai Cataldo)</li>
<li><a class="commit-link" href="https://urls.greenkeeper.io/eslint/doctrine/commit/a05e9f270dcb31c12999e1e5b6bac0335d904821"><tt>a05e9f2</tt></a> Upgrade: [email protected] (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="371258798" data-permission-text="Issue title is private" data-url="eslint/doctrine#220" data-hovercard-type="pull_request" data-hovercard-url="/eslint/doctrine/pull/220/hovercard" href="https://urls.greenkeeper.io/eslint/doctrine/pull/220">#220</a>) (Teddy Katz)</li>
<li><a class="commit-link" href="https://urls.greenkeeper.io/eslint/doctrine/commit/36ed02794b7d65339366f77a6f90892eadeee6cf"><tt>36ed027</tt></a> Chore: upgrade coveralls to ^3.0.1 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="325899308" data-permission-text="Issue title is private" data-url="eslint/doctrine#213" data-hovercard-type="pull_request" data-hovercard-url="/eslint/doctrine/pull/213/hovercard" href="https://urls.greenkeeper.io/eslint/doctrine/pull/213">#213</a>) (Teddy Katz)</li>
<li><a class="commit-link" href="https://urls.greenkeeper.io/eslint/doctrine/commit/8667e34a3ecf377d119d1dab4376c8be71fd95bf"><tt>8667e34</tt></a> Upgrade: eslint-release@^0.11.1 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="310208286" data-permission-text="Issue title is private" data-url="eslint/doctrine#210" data-hovercard-type="pull_request" data-hovercard-url="/eslint/doctrine/pull/210/hovercard" href="https://urls.greenkeeper.io/eslint/doctrine/pull/210">#210</a>) (Kevin Partington)</li>
</ul>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 6 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/eslint/doctrine/commit/42434ca1f85b264a88afcfd317487a7417e6004b"><code>42434ca</code></a> <code>3.0.0</code></li>
<li><a href="https://urls.greenkeeper.io/eslint/doctrine/commit/9655671fb175decb8f3969f3442aec4fad4922d6"><code>9655671</code></a> <code>Build: changelog update for 3.0.0</code></li>
<li><a href="https://urls.greenkeeper.io/eslint/doctrine/commit/0b5a8c78824798ded2329001723886e8269da08d"><code>0b5a8c7</code></a> <code>Breaking: drop support for Node &lt; 6 (#223)</code></li>
<li><a href="https://urls.greenkeeper.io/eslint/doctrine/commit/a05e9f270dcb31c12999e1e5b6bac0335d904821"><code>a05e9f2</code></a> <code>Upgrade: [email protected] (#220)</code></li>
<li><a href="https://urls.greenkeeper.io/eslint/doctrine/commit/36ed02794b7d65339366f77a6f90892eadeee6cf"><code>36ed027</code></a> <code>Chore: upgrade coveralls to ^3.0.1 (#213)</code></li>
<li><a href="https://urls.greenkeeper.io/eslint/doctrine/commit/8667e34a3ecf377d119d1dab4376c8be71fd95bf"><code>8667e34</code></a> <code>Upgrade: eslint-release@^0.11.1 (#210)</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/eslint/doctrine/compare/fdd0004782f218c4362fd928d82ef0e84a8e64d3...42434ca1f85b264a88afcfd317487a7417e6004b">full diff</a></p>
</details>

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴
@Ramyromel Ramyromel mentioned this pull request Aug 10, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nzakas nzakas nzakas approved these changes

@platinumazure platinumazure platinumazure approved these changes

@btmills btmills btmills approved these changes

@mysticatea mysticatea mysticatea approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kaicataldo @coveralls @nzakas @platinumazure @btmills @mysticatea