Skip to content
This repository was archived by the owner on May 7, 2023. It is now read-only.

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Oct 28, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
xo 0.45.0 -> 0.46.3 age adoption passing confidence

Release Notes

xojs/xo

v0.46.3

Compare Source

  • Fix an issue with npm not including bundledDependencies when publishing.

v0.46.2

Compare Source

  • Fix an issue with importing a dependency 653887a

v0.46.1

Compare Source

  • Fix an issue with npm not including bundledDependencies when publishing.

v0.46.0

Compare Source

Breaking
New rules
Improvements
Fixes

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added renovate By Renovate bot renovate/development Renovate bot development dependencies updates labels Oct 28, 2021
@esdmr
Copy link
Owner

esdmr commented Oct 28, 2021

Is this a regression of xojs/xo#624? v0.64.1 fixed another, but it seems that linting now requires building typescript first if there is a tsconfig project referencing another. Huh.

@voxpelli
Copy link

@esdmr test again with 0.46.3

@renovate renovate bot force-pushed the renovate/xo-0.x branch from 8e5d230 to 7f3b752 Compare October 28, 2021 10:39
@renovate renovate bot changed the title Update dependency xo to v0.46.1 Update dependency xo to v0.46.3 Oct 28, 2021
@esdmr
Copy link
Owner

esdmr commented Oct 28, 2021

@voxpelli Hello! The issue (with tsconfig) seems to persist even after upgrading to [email protected]. I can fix it on my repos for now.

I wonder if this is a bug in typescript-eslint, Maybe a version mismatch? I will try investigating a little.

@voxpelli
Copy link

@esdmr I had a PR merged to xo which bundles the typescript ESLint code with the xo release, to fix issues with npm 6. It could have caused a regression. Can you open an issue in the xo repo and ping me in it?

@esdmr
Copy link
Owner

esdmr commented Oct 28, 2021

@voxpelli Hello again. I have done some tests. Seems that this issue is not related to xo. In fact, xo is now consistent with eslint in that it errors in the new release.

For reference, the minimal working example is at esdmr/ts-eslint-bug-mwe.

Have a nice day!

esdmr added a commit that referenced this pull request Oct 28, 2021
Ref: #107
@esdmr esdmr mentioned this pull request Oct 28, 2021
esdmr added a commit that referenced this pull request Oct 28, 2021
@renovate renovate bot force-pushed the renovate/xo-0.x branch from 7f3b752 to 24ca72b Compare October 28, 2021 13:26
@renovate renovate bot force-pushed the renovate/xo-0.x branch from 24ca72b to 821da49 Compare October 29, 2021 01:36
@renovate renovate bot merged commit f79f07f into master Oct 31, 2021
@renovate renovate bot deleted the renovate/xo-0.x branch October 31, 2021 09:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

renovate/development Renovate bot development dependencies updates renovate By Renovate bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants