ERR not Rejoining HIPCHAT Rooms

[bubba-h57]

Occasionally my ERR bot drops out of our teams main HIPCHAT channel and doesn't return. I have to open a private message and restart him in order to get him to come back.

[gbin]

Thx a lot for your report, I gonna split it as they are 2 different issues there : #60

[gbin]

May I ask you for the logs around when Err is kicked out of the room ? Is it after a long moment of inactivity ?
Thx

[bubba-h57]

I've not been keeping logs, so I will need to do that. I believe it is after long inactivity.

[zoni]

I've been seeing the same issue as well, Err isn't rejoining channels after being disconnected (This bot runs on HipChat as well, fwiw).

At first I thought it only happened when HipChat kicked the bot due to inactivity, but I just noticed it happened after losing connection as well.

Here's a debug log from around that time: https://gist.github.com/3689379

[gbin]

Thx a lot ! I think this time I squashed it. Simply on disconnection a "connected" flag was not resetted.
Try 05fefde or master

Now I have this behavior after a disconnection (see emphasis):

DEBUG:Closed shelf of Snippets
WARNING:Connection lost, retry to connect in 10 seconds.
INFO:Start Connection ...........
INFO:Connect attempt
INFO:Auth attempt
INFO:Connection established
INFO:Send Hello to everyone
INFO:Get Roster
INFO:* roster ***
INFO: 24926_143886@chat.hipchat.com
INFO: 24926_143884@chat.hipchat.com
INFO:* roster ***
INFO:Registered handler: message
INFO:Registered handler: presence
INFO:............ Connection Done
INFO:Activate internal commands
INFO:Activating all the plugins...
INFO:Activate plugin: Webserver
INFO:Activating Webserver with min_err_version = 1.6.4 and max_version = 1.6.4
DEBUG:Templates directory found for this plugin [/home/gbin/projects/err/errbot/builtins/templates]
DEBUG:Activating plugin: bots.Webserver
INFO:Webserver is not configured. Forbid activation
INFO:Activate plugin: VersionChecker
INFO:Activating VersionChecker with min_err_version = 1.6.4 and max_version = 1.6.4
DEBUG:Templates directory found for this plugin [/home/gbin/projects/err/errbot/builtins/templates]
DEBUG:Activating plugin: bots.VersionChecker
DEBUG:Checking version
DEBUG:Programming the polling of version_check every 86400 seconds with args [] and kwargs {}
DEBUG:Init storage for VersionChecker
DEBUG:Loading /home/gbin/tmp/r2/plugins/VersionChecker.db
DEBUG:Opened shelf of VersionChecker
INFO:Activate plugin: ChatRoom
INFO:Activating ChatRoom with min_err_version = 1.6.4 and max_version = 1.6.4
DEBUG:Templates directory found for this plugin [/home/gbin/projects/err/errbot/builtins/templates]
DEBUG:Activating plugin: bots.ChatRoom
DEBUG:Init storage for ChatRoom
DEBUG:Loading /home/gbin/tmp/r2/plugins/ChatRoom.db
DEBUG:Opened shelf of ChatRoom
DEBUG:Programming the polling of keep_alive every 10 seconds with args [] and kwargs {}
INFO:Activate plugin: Snippets
INFO:Activating Snippets with min_err_version = None and max_version = None
DEBUG:No templates directory found for this plugin [Looking for /home/gbin/projects/err-snippets/templates]
DEBUG:Activating plugin: bots.Snippets
DEBUG:Init storage for Snippets
DEBUG:Loading /home/gbin/tmp/r2/plugins/Snippets.db
DEBUG:Opened shelf of Snippets
DEBUG:Adding command : snippet_add -> snippet_add
INFO:
INFO:Notifying connection to all the plugins...
INFO:Callback_connect
INFO:Join room 24926_err@conf.hipchat.com
INFO:
INFO:Plugin activation done.

[zoni]

Looks good! I just bumped our version up to the latest, will keep an eye on the logs and let you know if it's fixed for sure or not

[zoni]

I can confirm that 05fefde has fixed the issue

[gbin]

Awesome thx