Add back long prefix check with mkfs version check#12
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a mkfs.erofs version gate so tests can skip when the installed mkfs is older than the version that contains the relevant fix (mkfs 1.9+), while also reintroducing long xattr prefix checks in test mkfs invocations.
Changes:
- Introduce
internal/erofstest.CheckMkfsVersionwith basic semver parsing/comparison and mkfs.erofs--versionprobing. - Skip
TestBasicwhen mkfs.erofs is older than 1.9. - Add
--xattr-prefixflags (short + long) to mkfs args used during test image creation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| internal/erofstest/mkfs.go | Adds mkfs.erofs version detection and semver comparison helper used by tests. |
| erofs_test.go | Skips a test on old mkfs versions and appends xattr prefix flags to mkfs test invocations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hsiangkao
reviewed
Mar 11, 2026
hsiangkao
reviewed
Mar 11, 2026
There is a relevant fix available in mkfs 1.9, skip older version to prevent test failure. Signed-off-by: Derek McGowan <derek@mcg.dev>
dmcgowan
force-pushed
the
fix-long-prefix-tests
branch
from
0cf32e1 to
f22409c
Compare
hsiangkao
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a relevant fix available in mkfs 1.9, skip older version to prevent test failure.