Refactor/cleanup binary_to_term impl (dec_term) #10136
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Let dec_term() accept NULL instead of a faked ErtsDistExternal without the large atom cache table. * Add 'flags' argument to dec_term() and friends. * Move boolean argument 'internal_nc' flag into 'flags' as new flag bit ERTS_DIST_EXT_INTERNAL_NC. * Add dec_sysname() to only accept NIL as local node when we decode node names.
Less fancy interleaved case and if
sverker
added
team:VM
CT Test Results 3 files 142 suites 49m 58s ⏱️ Results for commit 8813f1d. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically a code cleanup after PR #9759 which was a quick and dirty performance fix that came late into OTP 28.0.