Callback module selection for (gen_tcp) listen, connect and (gen_udp) open (OTP-19695) #10013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The order of the options (when calling gen_tcp:[listen|connect] or gen_udp:open) should not have any effect of if the module option (tcp_module for gen_tcp or udp_module for gen_udp) is choosen. OTP-19695
Add (gen_tcp) listen test case for module option testing. OTP-19695
Add (gen_tcp) connect test case for module option testing. OTP-19695
Add (gen_udp) open test case for module option testing. OTP-19695
CT Test Results 2 files 71 suites 1h 6m 45s ⏱️ For more details on these failures, see this check. Results for commit fca8ef3. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
rickard-green
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of the options, should not effect selection of the callback module (when the module option has been provided).