Support wonky names and missing names in commit #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit names can have some pretty weird stuff! Here is a real commit from the LLVM repo ``` commit a062856bcf4fca26dab06afdf14bf1c815831f9c Author: --global <[email protected]> Date: Mon Oct 28 08:53:44 2019 -0700 [NFC] Comment endif to test commit access ``` Turns out that passing this to the mail client would fail since the `--` turns it to become an option. Also fixed the case where author names are missing. fixes erikbern#90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit names can have some pretty weird stuff!
Here is a real commit from the LLVM repo
Turns out that passing this to the mail client would fail since the
--turns it to become an option.Also fixed the case where author names are missing.
fixes #90