Fix sum calculation for other categories in stack plot#103
Open
gb1035 wants to merge 1 commit intoerikbern:masterfrom
Open
Fix sum calculation for other categories in stack plot#103gb1035 wants to merge 1 commit intoerikbern:masterfrom
gb1035 wants to merge 1 commit intoerikbern:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like numpy had deprecated passing in a generator to numpy.sum: https://numpy.org/devdocs/release/2.4.0-notes.html#numpy-array2string-and-numpy-sum-deprecations-finalized
So I've replaced numpy sum with a python-native sum. Also adding the start parameter to ensure the output has the correct size/shape for the 2d array.
Fair warning, I did use an LLM to do a lot of the analysis here, I couldn't find any contributors guide so figured I'd call that out here in case that was an issue. I did test this locally and it looks right to me.