snapshots: more state schema configurations #2509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
battlmonstr
commented
Nov 14, 2024
battlmonstr
commented
- .kvei and .bt schema (only schema for now, TODOs added for opening files)
- configure KVSegment compression kind: uncompressed by default, Storage & Commitment .kv has keys compressed, Code .kv has values compressed (.ef is always uncompressed)
- configure Segment compression: history is uncompressed by default, compressed for Code .v
- disable Commitment history
auto-merge was automatically disabled
November 14, 2024 11:18
Pull request was converted to draft
battlmonstr
force-pushed
the
pr/e3path
branch
from
31c3355 to
a18afad
Compare
battlmonstr
force-pushed
the
pr/schema2
branch
from
e754f3f to
55432ca
Compare
battlmonstr
force-pushed
the
pr/schema2
branch
from
55432ca to
064afae
Compare
canepat
approved these changes
Nov 20, 2024
|
|
||
| std::pair<std::optional<SegmentAndIndex>, std::shared_ptr<SnapshotBundle>> find_segment( | ||
| std::pair<datastore::EntityName, datastore::EntityName> names, | ||
| std::array<datastore::EntityName, 3> names, |
Member
There was a problem hiding this comment.
It would be better to insert a using declaration for std::array<datastore::EntityName, 3>, as it is used in 4 different places
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.