-
Notifications
You must be signed in to change notification settings - Fork 6
Open
Labels
P1medium prioritymedium priorityURGENTmust be dealt with ASAPmust be dealt with ASAPX [isolation]improved interpreter isolationimproved interpreter isolationX [runtime]CPython runtime (lifecycle, state)CPython runtime (lifecycle, state)complexity: mediummoderately hard to figure outmoderately hard to figure outsize: largerequires a lot of changesrequires a lot of changesstatus: blockedwaiting for another issuewaiting for another issuetype: code health
Description
(blocked by #47)
When check-c-globals.py
runs it fails if it finds any static variables that it determines should not actually be global (e.g. hold per-interpreter runtime state). Currently have a fixed list of globals that we ignore, which would otherwise cause the script to fail. It needs to pass without such a list.
That list is stored in Tools/c-globals/ignored-globals.txt
(or its replacement, e.g. Tools/c-analyzer/c_statics/ignored.tsv
).
Here are the concrete steps we need to take:
- resolve each unsupported variable found by
Tools/c-analyzer/c-statics.py
- stop using the
--ignored
arg inLib/test/test_check_c_statics.py
- remove the
Tools/c-analyzer/c_statics/ignored.tsv
file
Metadata
Metadata
Assignees
Labels
P1medium prioritymedium priorityURGENTmust be dealt with ASAPmust be dealt with ASAPX [isolation]improved interpreter isolationimproved interpreter isolationX [runtime]CPython runtime (lifecycle, state)CPython runtime (lifecycle, state)complexity: mediummoderately hard to figure outmoderately hard to figure outsize: largerequires a lot of changesrequires a lot of changesstatus: blockedwaiting for another issuewaiting for another issuetype: code health