new default: no public plaintext listener#801
Merged
slingamn merged 1 commit intoergochat:masterfrom Feb 23, 2020
Merged
Conversation
Contributor
|
Yeah, if you're running in docker per the README in dist/docker then it will still expose 6667. But docker's not doing anything clever - if the ora binary isn't listening on 6667 then connections will fail in basically the same way they'd fail if it was running on bare-metal. (If this lands we should update the docker bits though, as it'll be weird and confusing to expose a port we're not listening on!) |
Member
|
Yep, let's do this |
DanielOaks
approved these changes
Feb 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@DanielOaks I won't merge this without your approval.
I feel like public plaintext is a bad default for 2020, and goes against the ideas in ircv3/ircv3-ideas#45. But if you think this is an unfriendly default, or insufficiently batteries-included, I get it.
@csmith I'm not 100% clear on how this would interact with the Docker configs; would 6667 still be exposed despite this change, because of
EXPOSEand-p?