remove oragono.io/maxline-2 and fmsgid#752
Merged
slingamn merged 2 commits intoergochat:masterfrom Jan 26, 2020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes maxline support, and also makes our multiline implementation conform to the current version of ircv3/ircv3-specifications#398 (no fallback msgids, fallback PRIVMSG other than the first are sent without a msgid).
I feel conflicted about this because I think it makes
CHATHISTORYharder for client developers to use (unless they add full support for multiline, they won't be able to deduplicate all history messages by msgid). But I'm not sure there's much appetite for a solution that avoids this.