fix an edge case in skeletonization#562
Merged
DanielOaks merged 1 commit intoergochat:masterfrom Jun 18, 2019
Merged
Conversation
'm' skeletonizes to 'rn' (but is exempted by the isBoring check), but the fullwidth 'ｍ' does not skeletonize to anything. The root cause of this is the (still unexplained) patchiness of the skeleton mapping for fullwidth -> standard-width Latin characters; the fix is to perform width mapping first, before either skeletonization or isBoring.
Member
|
Great fix, real good to get in before the final. Thanks for the report! |
slingamn
added a commit
to ergochat/confusables
that referenced
this pull request
Jun 19, 2019
This is necessary for a more complete fix for ergochat/ergo#562
DanielOaks
added a commit
that referenced
this pull request
Jun 24, 2019
more systematic fix for #562
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation in the commit message.
Since this is a potential security issue, it's a candidate for merging now, before the final release.