Conversation
Some clients seem to automatically poll for channel state
If you were banned and the ban was only detected when you proxied (because you were proxying from a DLINE'd IP), you'd get an incorrect quit message: `QUIT: Bad or unauthorized PROXY command`. This propagates the correct ban message as the quit line.
|
While I don't mind removing most of the indirection, I find it a little more interesting to explicitly need to declare the maps yourself now before safe use (unless you use the ApplyConfig, obv). Weird tradeoff of being indirect and having the maps defined for you vs direct and if you use 'em directly them you'll run into issues. Looks like it shouldn't be a drama though given how we use them (gosh I wish Go just make()'d the maps for you when you created a struct, that'd make it so dang easy). |
|
Great set of QoL fixes, thanks for the lovely PR |
|
Yeah, the pattern I've been going for in general is to replace I asked in #go-nuts about that map behavior and they called it autovivification and said it was bad, and I remember being moderately convinced at the time but I don't remember their arguments. ergochat/irc-go#11 did some autovivification-like behavior on the |
The individual commits should be mostly self-documenting.