Merged
Conversation
slingamn
requested changes
Apr 28, 2019
irc/client_lookup_set.go
Outdated
| defer clients.RUnlock() | ||
| for _, client := range clients.byNick { | ||
| for _, session := range client.Sessions() { | ||
| capabs = append(capabs, caps.CapNotify) |
Member
There was a problem hiding this comment.
This appends an extra copy of caps.CapNotify on every iteration, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like cap-notify's been a little busted. Not related to the bnc stuff, just in general probably. This PR fixes that up a little.
It seems there's still s'more to do with regards to getting the values to be passed-thru on cap value replies, seems to be sending out empty lines currently. The SASL enable/disable block should reeeally just use the same structure as the STS section below, that handles things a whole lot more nicely.
Issues this should resolve:
CAP LS 302they won't automagically receivecap-notifymessages (as the spec indicates they should). This PR should mean they will, without having to explicitly request that capability separately.CAP LS 303, they won't get any of the302stuff (specifically, the auto-cap-notifybehaviour above). This PR should mean they will.Issues to be resolved:
saslin particular, dunno exactly what's going on there.