fix: make SAGET/SASET responses reference target account#2360
Open
saschabuehrle wants to merge 1 commit intoergochat:masterfrom
Open
fix: make SAGET/SASET responses reference target account#2360saschabuehrle wants to merge 1 commit intoergochat:masterfrom
saschabuehrle wants to merge 1 commit intoergochat:masterfrom
Conversation
slingamn
reviewed
Mar 13, 2026
Member
slingamn
left a comment
slingamn
left a comment
There was a problem hiding this comment.
Thank you very much for looking into this issue!
| service.Notice(rb, fmt.Sprintf(client.t("Your stored always-on setting is: %s"), userPersistentStatusToString(stored))) | ||
| } | ||
| if actual { | ||
| service.Notice(rb, client.t("Given current server settings, your client is always-on")) |
Member
There was a problem hiding this comment.
Note that the issue applies here as well:
- anything in
displaySettingthat references "you" or "your" - "Successfully changed your account settings" in
nsSetHandler - Possibly other places
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
#1197 — SAGET and SASET responses use "your" wording even when an operator is reading or modifying another account.
Fix
Testing
go test ./irc -run '^$'(package compile check)Happy to address any feedback.
Greetings, saschabuehrle