update bcrypt-cost comments to also add highest possible value#2311
Closed
rys wants to merge 1 commit intoergochat:masterfrom
Closed
update bcrypt-cost comments to also add highest possible value#2311rys wants to merge 1 commit intoergochat:masterfrom
rys wants to merge 1 commit intoergochat:masterfrom
Conversation
Member
|
This should be a config validation error, I'll make a PR for that later :-) |
Member
|
Out of curiosity, what cost did you end up using? We default to the minimum cost to speed up reconnection, especially for mobile clients. I'm interested in how operators are seeing those tradeoffs. |
slingamn
added a commit
to slingamn/ergo
that referenced
this pull request
Dec 22, 2025
Validate bcrypt-cost config value to prevent silent errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While configuring a new server I mistakenly set
bcrypt-costin my server config to something much higher than allowed.The error propagation for the passphrase checking logic returns the same error code for multiple paths out of that logic, so it took a good while to work out exactly why new account registration was failing after my misconfiguration.
Hopefully adding a note to the comments above
bcrypt-costin the config examples will help others discover their mistake in the same situation.