Skip to content

fix #2244 #2247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slingamn merged 2 commits into from
Apr 22, 2025
Merged

fix #2244 #2247

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5569cc
fix #2244
slingamn Apr 21, 2025
6d494db
clearer error message
slingamn Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion irc/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,10 @@ const (
PingCoalesceThreshold = time.Second
)

const (
utf8BOM = "\xef\xbb\xbf"
)

var (
MaxLineLen = DefaultMaxLineLen
)
Expand Down Expand Up @@ -750,7 +754,11 @@ func (client *Client) run(session *Session) {
continue
} // else: proceed with the truncated line
} else if err != nil {
client.Quit(client.t("Received malformed line"), session)
message := "Received malformed line"
if strings.HasPrefix(line, utf8BOM) {
message = "Received UTF-8 byte-order mark, which is invalid at the start of an IRC protocol message"
}
client.Quit(message, session)
break
}

Expand Down