clean up RPL_CHANNELMODEIS logic#2163
Merged
slingamn merged 2 commits intoergochat:masterfrom Jun 4, 2024
Merged
Conversation
Don't send RPL_CHANNELMODEIS for no-op changes to modes that take arguments (channel-user modes like +o, key, etc.)
Member
Author
|
I'm going to go ahead and merge this, but feel free to post comments later. |
This affects some cases like `MODE #chan Ii` as an unprivileged user; the +I invite-exception list cannot be listed without privileges, but +i can.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @DanielOaks and @progval for thoughts. The last time we revisited this was probably #649. This change has the following effects:
RPL_CHANNELMODEISandRPL_CREATIONTIMEforMODE #chan(standard behavior)MODE #chan i(most ircds translate this into +i, but it shouldn't matter)MODE #chan +iwhen it is a no-op because+iwas already enabled (most ircds will send nothing)MODE #chan +o nickwhen it fails or is a no-opMODE #chan b(standard behavior, fixed in Ergo by 324 RPL_CHANNELMODEIS sent after listing bans #649)+kand similar modes that take an argument is not changed (the operation is always broadcasted even when it is a no-op)