exempt a configurable number of MARKREAD commands from fakelag#1978
Merged
slingamn merged 4 commits intoergochat:masterfrom Aug 23, 2022
Merged
exempt a configurable number of MARKREAD commands from fakelag#1978slingamn merged 4 commits intoergochat:masterfrom
slingamn merged 4 commits intoergochat:masterfrom
Conversation
Member
Author
|
Note: can we zero-rate no-op JOIN commands? This helps with clients (like Goguma) attempting to rejoin all channels on reconnection. (However, the long-term fix for this involves communicating that the server is maintaining presence and the client should not attempt to rejoin channels: this prevents the client from rejoining channels that were PART'ed from a different session.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @emersion @progval
This is intended to solve slow reattaches by Goguma after ircv3/ircv3-specifications#489; right now, Goguma sends enough MARKREAD commands to trigger fakelag.
This change seems fairly low risk. The main thing I'm concerned about is that the config file is part of the "public API" of Ergo, so to speak, so I want to be sure that the
command-budgetsconcept is sufficiently expressive and reasonably future-proof.