Skip to content

make MaxLineLen configurable#1651

Merged
slingamn merged 2 commits intoergochat:masterfrom
slingamn:configurable_linelen
May 24, 2021
Merged

make MaxLineLen configurable#1651
slingamn merged 2 commits intoergochat:masterfrom
slingamn:configurable_linelen

Conversation

@slingamn
Copy link
Copy Markdown
Member

This is somewhat irresponsible, but I know someone who patches this value out for a private server, and this would allow them to use official builds.

This is similar to globalUtf8EnforcementSetting; it's set on initial config load and can't be modified subsequently, so the application code can read it without any data race.

@slingamn slingamn added this to the v2.7 milestone May 24, 2021
@DanielOaks
Copy link
Copy Markdown
Member

Yeah I don't mind this existing, sounds alright.

Can we make this live in limits: instead? The comment's great, but maybe we could make the "do not do this on a public server:" part all uppercase to especially discourage people from doing it?

@slingamn
Copy link
Copy Markdown
Member Author

I sort of feel like --- limits are the knobs that are safe to turn, this one is off by itself because you're not supposed to turn it. +1 on the all caps though.

@DanielOaks
Copy link
Copy Markdown
Member

Maybe we should just make a new config section called omg-pls-dont :P

But yeah I guess that tracks. I'm fine with it staying here then. LGTM

@slingamn slingamn merged commit 588efd2 into ergochat:master May 24, 2021
@slingamn slingamn deleted the configurable_linelen branch January 28, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants