Skip to content

don't add trailing = to ISUPPORT tokens when value is empty string#1070

Merged
slingamn merged 2 commits intoergochat:masterfrom
jesopo:isupport-equals
Jun 1, 2020
Merged

don't add trailing = to ISUPPORT tokens when value is empty string#1070
slingamn merged 2 commits intoergochat:masterfrom
jesopo:isupport-equals

Conversation

@jesopo
Copy link
Copy Markdown
Contributor

@jesopo jesopo commented May 26, 2020

fixes #1069

@slingamn
Copy link
Copy Markdown
Member

Thanks!

So, first I want to confirm with Dan that we want to make this change. But if we're doing it, it would be cool if we could clean up the whole use of *string here, and make Tokens a map[string]string.

@slingamn
Copy link
Copy Markdown
Member

Delightful, I'll merge this next week pending Dan's approval.

@DanielOaks
Copy link
Copy Markdown
Member

Coolcool, yeah they're semantically the same so should be fine. Cleaner so let's do it~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

consider sending value-less ISUPPORT parameters without =

3 participants