don't add trailing = to ISUPPORT tokens when value is empty string#1070
Merged
slingamn merged 2 commits intoergochat:masterfrom Jun 1, 2020
jesopo:isupport-equals
Merged
don't add trailing = to ISUPPORT tokens when value is empty string#1070slingamn merged 2 commits intoergochat:masterfrom jesopo:isupport-equals
slingamn merged 2 commits intoergochat:masterfrom
jesopo:isupport-equals
Conversation
Member
|
Thanks! So, first I want to confirm with Dan that we want to make this change. But if we're doing it, it would be cool if we could clean up the whole use of |
Member
|
Delightful, I'll merge this next week pending Dan's approval. |
Member
|
Coolcool, yeah they're semantically the same so should be fine. Cleaner so let's do it~ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1069