Skip to content

fix TAGMSG playback#1044

Merged
slingamn merged 1 commit intoergochat:masterfrom
slingamn:tagmsg_fix
May 22, 2020
Merged

fix TAGMSG playback#1044
slingamn merged 1 commit intoergochat:masterfrom
slingamn:tagmsg_fix

Conversation

@slingamn
Copy link
Copy Markdown
Member

  1. TAGMSG were incorrectly being considered multilines, because Is512() was checking the wrong thing, and then not getting replayed at all (unclear whether this is a bug in 2.0.0 or a regression from development, so not sure whether it gets a changelog entry)
  2. Playback of TAGMSG should depend on event-playback, not on message-tags (this is a bug in 2.0.0 and should get a changelog entry)

I wrote an irctest for this but GitHub won't let me PR it right now, whatever.

1. TAGMSG were incorrectly being considered multilines, because
   Is512() was checking the wrong thing
2. Playback of TAGMSG should depend on event-playback, not on message-tags
@slingamn slingamn added the bug label May 22, 2020
@slingamn slingamn added this to the v2.1 milestone May 22, 2020
@slingamn slingamn merged commit b80f92b into ergochat:master May 22, 2020
@slingamn slingamn deleted the tagmsg_fix branch August 7, 2020 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant