go mod tidy fails to pull due to renamed packages

[cornfeedhobo]

        github.com/ergochat/ergo/irc imports
        github.com/goshuirc/irc-go/ircfmt: github.com/goshuirc/irc-go@v0.5.0: parsing go.mod:
        module declares its path as: github.com/ergochat/irc-go
                but was required as: github.com/goshuirc/irc-go

replace github.com/goshuirc/irc-go => github.com/ergochat/irc-go v0.5.0

github.com/ergochat/ergo/irc imports
        github.com/oragono/go-ident: github.com/oragono/go-ident@v0.0.0-20230911071154-8c30606d6881: parsing go.mod:
        module declares its path as: github.com/ergochat/go-ident
                but was required as: github.com/oragono/go-ident

replace github.com/oragono/go-ident => github.com/ergochat/go-ident v0.0.0-20230911071154-8c30606d6881

        github.com/ergochat/ergo/irc imports
        github.com/goshuirc/irc-go/ircmatch: module github.com/goshuirc/irc-go@latest found (v0.5.0, replaced by github.com/ergochat/irc-go@v0.5.0), but does not contain package github.com/goshuirc/irc-go/ircmatch

[slingamn]

What version of ergo are you trying to build?

[cornfeedhobo]

Using it for some end to end testing:

package e2e

import (
	"testing"

	"github.com/ergochat/ergo/irc"
	"github.com/ergochat/ergo/irc/logger"
)

func TestInit(t *testing.T) {
	// Minimal configuration for the test server.
	cfg := irc.Config{
		Server: irc.ServerConfig{
			Name:   "test.server.local",
			Listen: []string{":6667"},
		},
		// You can extend the configuration as needed for the test.
	}

	srv, err := irc.NewServer(&cfg, logger.NewStandardLogger())
	if err != nil {
		t.Fatalf("failed to create server: %v", err)
	}

	// Run the server in the background.
	go srv.Run()
	defer srv.Shutdown()
}

No version specified, automatically pulled with go mod tidy.

[cornfeedhobo]

If I explicitly run go get github.com/ergochat/ergo@master then it updates go.mod in a non-conflicting way. This is very strange behavior.

[slingamn]

Ah yeah, importing our libraries isn't really supported because our tagged version is v2.x but our module path is still github.com/ergochat/ergo without v2. We don't provide any API stability guarantees for these packages in any case.

This is breaking go install github.com/ergochat/ergo@latest though, which would be nice to support, so I'll look into mitigating this.

In any case, I'm not sure this is a robust solution for your test code, because of the lack of stability guarantees...what are you trying to test? I might be able to advise on a different solution.

[slingamn]

Previous discussion: #1841 (comment)

tl;dr I think it would be hard to make this work in a sane, fully idiomatic way. The command would be something like go install github.com/ergochat/ergo/v2/cmd/ergo@latest which is easy to get wrong. As for irc/ it would probably have to go under internal/, because of the lack of stability.