incorrect CHGHOST when simultaneously changing nick and hostname

[slingamn]

[02:54:14 PM] <Geo-> Working with chghost (after I msg identify to the services), I get this:
[02:54:32 PM] <Geo-> [18:48:25] [@] :Geo_!vanosg@oragono.io NICK geo
[02:54:33 PM] <Geo-> [18:48:25] [@] :Geo_!vanosg@zt53d279eqs7u.oragono CHGHOST vanosg oragono.io
[02:55:05 PM] <Geo-> Note the nick associated with the CHGHOST- it is the 'old' nick, not the current nick.

We intentionally send the old nickmask, but we should only be sending the old hostname, not the old username.

[jesopo]

why are you intentionally sending a CHGHOST with the old nickname? that means we're receiving a CHGHOST for a user we no longer think exists

[DanielOaks]

I think what sling meant is that in the CHGHOST sending function, we intentionally send the 'old' nickmask (the nickmask from right before the change of the u@h), but that we shouldn't be sending the old nickname here. Just a race condition based on some incorrect assumptions about what's safe to goroutine, #1110 looks like it should solve this without a drama.

[jesopo]

ah misunderstand on my part. cool cool, no dramas indeed