feat: add option for higher sample precision in StreamConverter #95
Conversation
| # These 4 bytes indicate the data source for the SGZ file. Use 20 to indicate numpy. | ||
| buffer[76:80] = int_to_bytes(20) | ||
| if use_higher_samples_precision: | ||
| # higher precision minimum sample time/depth |
There was a problem hiding this comment.
I feel it is more readable if you define a function here
There was a problem hiding this comment.
this method is only a couple of lines and I think it would actually make it harder to read if we define another function for this
There was a problem hiding this comment.
I looked at the other parts of the function and it is not needed
| if use_higher_samples_precision: | ||
| # higher precision minimum sample time/depth | ||
| buffer[84:92] = double_to_bytes(source.samples[0]) | ||
| # higher precision sample interval (μs/m) |
There was a problem hiding this comment.
What would user expect when higher sample precision is enabled?
Should we add a comment specifying the data type and precision level?
There was a problem hiding this comment.
this is defined in the SeismicZFP Header in the file-specification.md
|
|
||
|
|
||
| def generate_fake_seismic(n_ilines, n_xlines, n_samples, min_iline=0, min_xline=0): | ||
| def generate_fake_seismic(n_ilines, n_xlines, n_samples, min_iline=0, min_xline=0, min_sample=0): |
There was a problem hiding this comment.
it's the minimum sample value for the z dimension of the cube. min_sample is the (missing) equivalent to the two other dimension of the cube, e.g. min_iline and min_xline. with min_sample you are able to specify where the cube starts in z dimension
ThomasRyschawyEquinor
deleted the
support-higher-stream-converter-samples-precision
branch
No description provided.