fix: updated schema and outcrop models #501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the outcrop data structure throughout the application by updating the API-generated types and adjusting the components accordingly. The changes transition from array-based basin and location data to simpler nullable fields, aligning with the updated API schema.
- Refactored
GetOutcropsDtostructure to use nullable single values for basin and location instead of arrays - Updated
OutcropTypeinterface to match the new data structure with nested location object - Modified components to access location data through the new structure (
region.location.locationNamevsregion.locations[0].locationName)
Reviewed Changes
Copilot reviewed 4 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Added trailing comma for consistency |
| src/stores/GlobalStore.tsx | Updated type from OutcropDto[] to GetOutcropsDto[] for outcrops state |
| src/components/OutcropAnalogue/OutcropSelect/OutcropSelect.tsx | Refactored to use new single-value location structure and basin field instead of arrays |
| src/components/OutcropAnalogue/OutcropAnalogueGroup/OutcropAnalogueGroup.tsx | Updated interface definition and table rendering to use new location structure |
| src/api/generated/types.gen.ts | Updated type definitions for outcrop DTOs with new structure including Delft3D types |
| src/api/generated/sdk.gen.ts | Added new Delft3D preprocess endpoint |
| src/api/generated/schemas.gen.ts | Updated schemas to reflect new outcrop structure and Delft3D additions |
| .eslintignore | Simplified to use wildcard pattern for generated files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/components/OutcropAnalogue/OutcropAnalogueGroup/OutcropAnalogueGroup.tsx
Show resolved
Hide resolved
…logueGroup.tsx Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.