Merged
Conversation
…tual training and validation accuracy in end-to-end test
tharvik
approved these changes
Feb 13, 2024
Collaborator
tharvik
left a comment
tharvik
left a comment
There was a problem hiding this comment.
hoo nice, you found out why, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #629
When uncommenting the titanic validator test (which was previously commented because the loss was NaN), I increased the accuracy minimum without noticing that the accuracy was tested at initialization, i.e., without any training.
Therefore, I lower the validator accuracy expectations (from 0.5 to 0.3) but I add assertions on minimum training and validation accuracy (both > 0.6) in the end-to-end test.