Skip to content

Fix extract_components #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2019
Merged

Fix extract_components #42

merged 1 commit into from
Feb 18, 2019

Conversation

cafeal
Copy link
Contributor

@cafeal cafeal commented Feb 18, 2019

Current extract_components have a bug.
It may return the whole graph in any non-connected graphs since stack is initialized all indices of nodes.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.632% when pulling 0de6c63 on 69guitar1015:fix_extract_components into 9950c66 on epfl-lts2:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.632% when pulling 0de6c63 on 69guitar1015:fix_extract_components into 9950c66 on epfl-lts2:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.632% when pulling 0de6c63 on 69guitar1015:fix_extract_components into 9950c66 on epfl-lts2:master.

@mdeff mdeff merged commit 78034de into epfl-lts2:master Feb 18, 2019
@mdeff
Copy link
Collaborator

mdeff commented Feb 18, 2019

Thanks!

@mdeff mdeff mentioned this pull request Mar 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cafeal @coveralls @mdeff