Adds GatewayClass Watch to Gateway Controller #412
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danehans
force-pushed
the
issue_301_part3
branch
2 times, most recently
from
aa93ea0 to
a5f3c1d
Compare
danehans
force-pushed
the
issue_301_part3
branch
from
a5f3c1d to
5c3adb6
Compare
|
5c3adb6 rebases to pull in CI conformance test coverage. |
danehans
force-pushed
the
issue_301_part3
branch
from
5c3adb6 to
4b0c734
Compare
|
Rebased to include #404. |
|
CI failing here |
danehans
force-pushed
the
issue_301_part3
branch
2 times, most recently
from
b8fcbe1 to
666968b
Compare
skriss
suggested changes
Sep 28, 2022
LukeShu
reviewed
Sep 28, 2022
danehans
force-pushed
the
issue_301_part3
branch
from
666968b to
049cd68
Compare
Signed-off-by: danehans <[email protected]>
danehans
force-pushed
the
issue_301_part3
branch
from
049cd68 to
c5fd9f3
Compare
|
I am seeing #464 when I create an httproute, gateway, and then gatewayclass with this PR. |
|
Closing in favor of fixing the issue as part of #413. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a watch for GatewayClass objects to the gateway controller. Gateways that reference the managed GatewayClass will be enqueued for reconciliation.
Partially Fixes: #301
Signed-off-by: danehans [email protected]