userspace socket: allow providing an existing PassthroughState when creating IoHandle pair #40748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reating IoHandle pair Signed-off-by: Joe Kralicky <[email protected]>
kyessenov
approved these changes
Aug 26, 2025
wtzhang23
pushed a commit
to wtzhang23/envoy
that referenced
this pull request
Aug 27, 2025
…reating IoHandle pair (envoyproxy#40748) Commit Message: userspace socket: allow providing an existing PassthroughState when creating IoHandle pair Additional Description: This change is to allow extensions to provide their own implementation of PassthroughState and/or derive from the default PassthroughStateImpl when creating userspace IoHandle pairs with the IoHandleFactory. Risk Level: Low; changes are backwards compatible Testing: Unit tests added Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):] Signed-off-by: Joe Kralicky <[email protected]>
|
My use case involves creating a pair of userspace socket handles in an upstream Network::SocketInterface::socket(), then passing one of them to a different thread to connect it to a data stream coming from a separate downstream client. The implementation of PassthroughState used here adds thread safety and allows registering a callback when its state changes (e.g. created->initialized). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: userspace socket: allow providing an existing PassthroughState when creating IoHandle pair
Additional Description:
This change is to allow extensions to provide their own implementation of PassthroughState and/or derive from the default PassthroughStateImpl when creating userspace IoHandle pairs with the IoHandleFactory.
Risk Level: Low; changes are backwards compatible
Testing: Unit tests added
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]