network: centralize IP parsing and unify on getaddrinfo() to avoid circular deps #40737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rcular deps Signed-off-by: Rohit Agrawal <[email protected]>
agrawroh
force-pushed
the
refact-ip-prse
branch
from
637ad27 to
72f8dde
Compare
yanavlasov
reviewed
Aug 18, 2025
| sockaddr_in sa4 = *reinterpret_cast<sockaddr_in*>(res->ai_addr); | ||
| os_sys_calls.freeaddrinfo(res); | ||
| sa4.sin_port = htons(port); | ||
| // Enforce strict dotted-quad by round-tripping via inet_ntop and requiring equality. |
There was a problem hiding this comment.
What errors will this catch? Can we just keep using inet_pton as before?
Converting back into string and comparing can be expensive for configs with a lot of addresses.
There was a problem hiding this comment.
I was trying to unify on getaddrinfo() but indeed I can just use inet_pton as before and save the unnecessary overhead.
Signed-off-by: Rohit Agrawal <[email protected]>
yanavlasov
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ntroduces a new
ip_address_parsing_libwhich provides helper methods to parse IPv4 and IPv6 addresses that usegetaddrinfo()withAI_NUMERICHOST|AI_NUMERICSERVfor numeric-only parsing. We have refactoredparseInternetAddressNoThrow()andparseInternetAddressAndPortNoThrow()to use these newly added helpers.Note: For IPv4, we enforce strict dotted-quad by round-tripping via
inet_ntopto avoid platform quirks and keep the behavior consistent.Fix #23952
Commit Message: network: centralize IP parsing and unify on getaddrinfo() to avoid circular deps
Additional Description: Refactor IP parsing logic and consolidate the scattered logic with a single low-level implementation.
Risk Level: Low
Testing: Added Unit Tests
Docs Changes: N/A
Release Notes: N/A