Skip to content

Refactoring: nonce() and DISTARRAY_BASE_NAME #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 29, 2014
Merged

Refactoring: nonce() and DISTARRAY_BASE_NAME #580

merged 4 commits into from
Aug 29, 2014

Conversation

bgrant
Copy link
Contributor

@bgrant bgrant commented Aug 18, 2014

A few small refactorings done while working on lazy eval:

  1. Split a nonce function out of uid in utils.
  2. Only defineDISTARRAY_BASE_NAME in one place.
  3. Add some docstrings to proxyize
  4. Replace some hardcoded values in mpi_engine

@bgrant bgrant added this to the 0.6 milestone Aug 18, 2014
@bgrant bgrant mentioned this pull request Aug 25, 2014
Open
@kwmsmith
Copy link
Contributor

LGTM.

kwmsmith added a commit that referenced this pull request Aug 29, 2014
@kwmsmith
Merge pull request #580 from enthought/refactor/nonce-and-basename
ccaef6d 
Refactoring: nonce() and DISTARRAY_BASE_NAME
@kwmsmith kwmsmith merged commit ccaef6d into master Aug 29, 2014
@kwmsmith kwmsmith deleted the refactor/nonce-and-basename branch August 29, 2014 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
easy refactoring
Projects
None yet
Milestone
0.6
Development

Successfully merging this pull request may close these issues.
2 participants
@bgrant @kwmsmith