[mob][photos] native video editor #7269
Draft
+4,039
−188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncoding Co-authored-by: Claude <[email protected]>
Co-authored-by: Claude <[email protected]>
- Add useNativeVideoEditor flag that enables native video export only for internal users - Update video_editor_page to check the flag and use FFmpeg for regular users - Restore FFmpeg export functionality in ExportService.exportVideo() - Native video editor remains available only for internal users and debug mode Co-authored-by: Claude <[email protected]>
- Add Media3TransformerProcessor with proper Effects setup - Use ScaleAndRotateTransformation for rotation operations - Apply effects to EditedMediaItem using Effects class - Fix import for androidx.media3.common.Effect - Support trim, rotate, and crop operations in unified processor Co-authored-by: Claude <[email protected]>
Modified video_editor package to support dimension overrides for proper aspect ratio handling of rotated videos. Swaps width/height when rotation metadata is 90/270 degrees and applies RotatedBox for correct display. Co-authored-by: Claude <[email protected]>
- Use swapped dimensions for crop calculation when metadata rotation exists - Fix crop coordinates to match dimensions used by crop grid viewer - Change Media3 Presentation mode from SCALE_TO_FIT to SCALE_TO_FIT_WITH_CROP - Pass metadata rotation from video editor to export service - Add dimension override support to trim/crop/rotate pages Co-Authored-By: Claude <[email protected]>
Co-Authored-By: Claude <[email protected]>
Co-authored-by: Claude <[email protected]>
prateekmedia
changed the title
… plugin Co-authored-by: Claude <[email protected]>
Co-authored-by: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make video editor experience better by using native api's. Resulting in more than 10x improvement in processing speed.
Tests