SimpleCharacter: Use methods for player movement #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 2 methods and call them, instead of having the implementation in the
code template ("statement" property).
This improves a bit when serializing the implementation. But most
importantly, allows the 2 blocks to be added to the same node without a
collision on the var dir being declared twice.
Make player 1, player 2 options, defaulting to player 1. And add default to speed too. A speed of Vector2(300,300) is very opinionated but seems fine for the default project viewport.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 2 methods and call them, instead of having the implementation in the code template ("statement" property).
This improves a bit when serializing the implementation. But most importantly, allows the 2 blocks to be added to the same node without a collision on the var dir being declared twice.