Skip to content

FIPS review #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from Aug 1, 2019
Merged

FIPS review #1

merged 4 commits into from Aug 1, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jul 29, 2019

  • Port _hmacopenssl to multiphase init.
  • Make _hmacopenssl.HMAC.copy create same type as self.
  • hmac.py cosmetic nitpick

Marcel Plch and others added 4 commits July 29, 2019 12:45
FIPS review
125430e 
* Port _hmacopenssl to multiphase init.
* Make _hmacopenssl.HMAC.copy create same type as self.
* hmac.py cosmetic nitpick
revert cosmetic nitpick and remove trailing whitespace
a7996ce
@stratakis
Add initial tests for various hashes under FIPS mode
6b74d9e
Initialize HMAC type.
64863fb
@encukou encukou merged commit 64863fb into encukou:fips Aug 1, 2019
encukou pushed a commit that referenced this pull request Jul 7, 2020
@tiran
bpo-40955: Fix memory leak in subprocess module (pythonGH-20825)
0d3350d 
```
Direct leak of 8 byte(s) in 1 object(s) allocated from:
    #0 0x7f008bf19667 in __interceptor_malloc (/lib64/libasan.so.6+0xb0667)
    #1 0x7f007a0bee4a in subprocess_fork_exec /home/heimes/dev/python/cpython/Modules/_posixsubprocess.c:774
    #2 0xe0305b in cfunction_call Objects/methodobject.c:546
```

Signed-off-by: Christian Heimes <[email protected]>
encukou pushed a commit that referenced this pull request Dec 8, 2020
@ssbr
bpo-40791: Make compare_digest more constant-time. (pythonGH-20444)
3172936 
* bpo-40791: Make compare_digest more constant-time.

The existing volatile `left`/`right` pointers guarantee that the reads will all occur, but does not guarantee that they will be _used_. So a compiler can still short-circuit the loop, saving e.g. the overhead of doing the xors and especially the overhead of the data dependency between `result` and the reads. That would change performance depending on where the first unequal byte occurs. This change removes that optimization.

(This is change #1 from https://bugs.python.org/issue40791 .)
encukou pushed a commit that referenced this pull request Jan 5, 2021
@miss-islington @ssbr
bpo-40791: Make compare_digest more constant-time. (pythonGH-20444)
97136d7 
* bpo-40791: Make compare_digest more constant-time.

The existing volatile `left`/`right` pointers guarantee that the reads will all occur, but does not guarantee that they will be _used_. So a compiler can still short-circuit the loop, saving e.g. the overhead of doing the xors and especially the overhead of the data dependency between `result` and the reads. That would change performance depending on where the first unequal byte occurs. This change removes that optimization.

(This is change GH-1 from https://bugs.python.org/issue40791 .)
(cherry picked from commit 3172936)

Co-authored-by: Devin Jeanpierre <[email protected]>
encukou pushed a commit that referenced this pull request Feb 10, 2021
@miss-islington @tiran
bpo-40955: Fix memory leak in subprocess module (pythonGH-20825)
ee3f7fe 
```
Direct leak of 8 byte(s) in 1 object(s) allocated from:
    GH-0 0x7f008bf19667 in __interceptor_malloc (/lib64/libasan.so.6+0xb0667)
    GH-1 0x7f007a0bee4a in subprocess_fork_exec /home/heimes/dev/python/cpython/Modules/_posixsubprocess.c:774
    GH-2 0xe0305b in cfunction_call Objects/methodobject.c:546
```

Signed-off-by: Christian Heimes <[email protected]>
(cherry picked from commit 0d3350d)

Co-authored-by: Christian Heimes <[email protected]>
encukou pushed a commit that referenced this pull request Feb 10, 2021
@miss-islington @ssbr
bpo-40791: Make compare_digest more constant-time. (pythonGH-20444)
c1bbca5 
* bpo-40791: Make compare_digest more constant-time.

The existing volatile `left`/`right` pointers guarantee that the reads will all occur, but does not guarantee that they will be _used_. So a compiler can still short-circuit the loop, saving e.g. the overhead of doing the xors and especially the overhead of the data dependency between `result` and the reads. That would change performance depending on where the first unequal byte occurs. This change removes that optimization.

(This is change GH-1 from https://bugs.python.org/issue40791 .)
(cherry picked from commit 3172936)

Co-authored-by: Devin Jeanpierre <[email protected]>
encukou pushed a commit that referenced this pull request Feb 2, 2022
@vstinner
bpo-46600: Fix test_gdb.test_pycfunction() for clang -Og (pythonGH-31058
bebaa95 
)

Fix test_gdb.test_pycfunction() for Python built with clang -Og.
Tolerate inlined functions in the gdb traceback.

When _testcapimodule.c is built by clang -Og, _null_to_none() is
inlined in meth_varargs() and so gdb returns _null_to_none() as
the frame #1. If it's not inlined, meth_varargs() is the frame #1.
encukou pushed a commit that referenced this pull request Apr 21, 2022
@gpshead
pythongh-89455: Fix an uninitialized bool in exception print context. (…
861974b 
…python#91466)

Fix an uninitialized bool in exception print context.
    
`struct exception_print_context.need_close` was uninitialized.
    
Found by oss-fuzz in a test case running under the undefined behavior sanitizer.
    
https://oss-fuzz.com/testcase-detail/6217746058182656
    
```
Python/pythonrun.c:1241:28: runtime error: load of value 253, which is not a valid value for type 'bool'
    #0 0xbf2203 in print_chained cpython3/Python/pythonrun.c:1241:28
    #1 0xbea4bb in print_exception_cause_and_context cpython3/Python/pythonrun.c:1320:19
    #2 0xbea4bb in print_exception_recursive cpython3/Python/pythonrun.c:1470:13
    #3 0xbe9e39 in _PyErr_Display cpython3/Python/pythonrun.c:1517:9
```
    
Pretty obvious what the ommission was upon code inspection.
encukou pushed a commit that referenced this pull request May 30, 2023
@miss-islington @ssbr
bpo-40791: Make compare_digest more constant-time. (pythonGH-23438) (p…
8bef9eb 
…ythonGH-23767)

The existing volatile `left`/`right` pointers guarantee that the reads will all occur, but does not guarantee that they will be _used_. So a compiler can still short-circuit the loop, saving e.g. the overhead of doing the xors and especially the overhead of the data dependency between `result` and the reads. That would change performance depending on where the first unequal byte occurs. This change removes that optimization.

(This is change GH-1 from https://bugs.python.org/issue40791 .)
(cherry picked from commit 3172936)

Co-authored-by: Devin Jeanpierre <[email protected]>
encukou pushed a commit that referenced this pull request Oct 13, 2023
@vstinner
Revert "pythongh-46376: Return existing pointer when possible in ctyp…
5a79d2a 
…es (#1… (python#108688)

This reverts commit 08447b5.

Revert also _ctypes.c changes of the PyDict_ContainsString() change,
commit 6726626.
encukou pushed a commit that referenced this pull request Jul 19, 2024
@vstinner
[3.12] Revert "[3.12] pythongh-69214: Fix fcntl.ioctl() request type (p…
34a0e7a 
…ython#119498) (#1… (python#119905)

Revert "[3.12] pythongh-69214: Fix fcntl.ioctl() request type (python#119498) (python#119505)"

This reverts commit 078da88.

The change modified how negative values, like termios.TIOCSWINSZ, was
treated and is actually backward incompatible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@encukou @stratakis