Skip to content

WRR-14491: Update jsdoc-to-ts to support Limestone #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

hong6316
Copy link
Contributor

@hong6316 hong6316 commented Jan 20, 2025

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • I have run automated testing and it is passed
  • This is an API breaking change

Issue Resolved / Feature Added

Update jsdoc-to-ts to support Limestone

Resolution

  • add '@enact/limestone' in importMap
  • update docs
  • update travis

Additional Considerations

Links

WRR-14491

Comments

Enact-DCO-1.0-Signed-off-by: Taeyoung Hong ([email protected])

@@ -54,7 +54,8 @@ const opts = minimist(process.argv.slice(2), {
moonstone: '@enact/moonstone',
Copy link
Contributor Author

@hong6316 hong6316 Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should moonstone and moonstone-ez need to be kept in here?

@@ -100,7 +100,7 @@ You also have to configure the app to resolve the generated typings by adding th
Assuming jsdoc-to-ts is installed and linked globally on the current device, and we want to run the command in one of the installed Enact packages (core, ui, i18n, etc.) folder:

```bash
jsdoc-to-ts --ignore='["node_modules", "ilib", "build", "docs", "tests", "samples"]' --importMap='{"core":"@enact/core","ui":"@enact/ui","spotlight":"@enact/spotlight","i18n":"@enact/i18n","webos":"@enact/webos","moonstone":"@enact/moonstone","agate":"@enact/agate","sandstone":"@enact/sandstone"}' --outputPath='.'
jsdoc-to-ts --ignore='["node_modules", "ilib", "build", "docs", "tests", "samples"]' --importMap='{"core":"@enact/core","ui":"@enact/ui","spotlight":"@enact/spotlight","i18n":"@enact/i18n","webos":"@enact/webos","moonstone":"@enact/moonstone","agate":"@enact/agate","sandstone":"@enact/sandstone","limestone":"@enact/limestone"}' --outputPath='.'
Copy link
Contributor Author

@hong6316 hong6316 Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should moonstone needs to be kept in here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant